Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 5809 batch alarms topic policy #392

Merged
merged 12 commits into from
Oct 17, 2024
Merged

fix: 5809 batch alarms topic policy #392

merged 12 commits into from
Oct 17, 2024

Conversation

Wi11Shell
Copy link
Contributor

Description

Related issue: https://dvsa.atlassian.net/browse/VOL-5809

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

@Wi11Shell Wi11Shell requested a review from a team as a code owner October 17, 2024 12:57
Copy link
Contributor

Terraform plan for environment: int

Commit: 6bdebbb

API version: 790df66
CLI version: 790df66
Selfserve version: 790df66
Internal version: 790df66

Plan summary

0 to add, 1 to change, 0 to destroy

🔄 Updates

module.service.module.sns_batch_failure.aws_sns_topic_policy.this[0]

Show full plan
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.service.module.sns_batch_failure.aws_sns_topic_policy.this[0] will be updated in-place
  ~ resource "aws_sns_topic_policy" "this" {
        id     = "arn:aws:sns:eu-west-1:054614622558:vol-app-int-batch-failure-topic-20241009140715202500000002"
      ~ policy = jsonencode(
          ~ {
              ~ Statement = [
                    # (1 unchanged element hidden)
                    {
                        Action    = "sns:Publish"
                        Effect    = "Allow"
                        Principal = {
                            AWS = "arn:aws:iam::054614622558:root"
                        }
                        Resource  = "arn:aws:sns:eu-west-1:054614622558:vol-app-int-batch-failure-topic-20241009140715202500000002"
                        Sid       = "pub"
                    },
                  ~ {
                      - Condition = {
                          - ArnLike = {
                              - "aws:SourceArn" = ""
                            }
                        }
                        # (5 unchanged attributes hidden)
                    },
                ]
                # (1 unchanged attribute hidden)
            }
        )
        # (2 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

Copy link
Contributor

Terraform plan for environment: dev

Commit: 6bdebbb

API version: 790df66
CLI version: 790df66
Selfserve version: 790df66
Internal version: 790df66

Plan summary

0 to add, 1 to change, 0 to destroy

🔄 Updates

module.service.module.sns_batch_failure.aws_sns_topic_policy.this[0]

Show full plan
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.service.module.sns_batch_failure.aws_sns_topic_policy.this[0] will be updated in-place
  ~ resource "aws_sns_topic_policy" "this" {
        id     = "arn:aws:sns:eu-west-1:054614622558:vol-app-dev-batch-failure-topic-20241009122927526300000002"
      ~ policy = jsonencode(
          ~ {
              ~ Statement = [
                    # (1 unchanged element hidden)
                    {
                        Action    = "sns:Publish"
                        Effect    = "Allow"
                        Principal = {
                            AWS = "arn:aws:iam::054614622558:root"
                        }
                        Resource  = "arn:aws:sns:eu-west-1:054614622558:vol-app-dev-batch-failure-topic-20241009122927526300000002"
                        Sid       = "pub"
                    },
                  ~ {
                      - Condition = {
                          - ArnLike = {
                              - "aws:SourceArn" = ""
                            }
                        }
                        # (5 unchanged attributes hidden)
                    },
                ]
                # (1 unchanged attribute hidden)
            }
        )
        # (2 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

@barkerl barkerl merged commit 65c86e4 into main Oct 17, 2024
@barkerl barkerl deleted the 5809-batch-alarms branch October 17, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants