Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: external vehicle search access bug vol 5828 #348

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

fibble
Copy link
Contributor

@fibble fibble commented Sep 23, 2024

Description

Resolves an RBAC issue allowing external access via direct URL to a search index intended only for some logged in users.

Related issue: VOL-5828

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

@fibble fibble requested review from ilindsay and a team as code owners September 23, 2024 15:30
@fibble fibble force-pushed the external-vehicle-search-access-bug-vol-5828 branch from e6149db to 42d986d Compare September 23, 2024 15:30
@fibble fibble changed the title External vehicle search access bug vol 5828 fix: external vehicle search access bug vol 5828 Sep 23, 2024
@ilindsay ilindsay merged commit 05e8d21 into main Sep 23, 2024
19 of 20 checks passed
@ilindsay ilindsay deleted the external-vehicle-search-access-bug-vol-5828 branch September 23, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants