fix: VOL-5226 irfo gv permits now locked down for read only users (dv…

…sa/olcs-internal#161)
dvsa · May 9, 2024 · ae1f14b · ae1f14b
1 parent 1309aba
commit ae1f14b
Show file tree

Hide file tree

Showing 3 changed files with 64 additions and 32 deletions.
diff --git a/app/internal/module/Olcs/src/Controller/Operator/OperatorIrfoGvPermitsController.php b/app/internal/module/Olcs/src/Controller/Operator/OperatorIrfoGvPermitsController.php
@@ -2,6 +2,10 @@
 
 namespace Olcs\Controller\Operator;
 
+use Common\Rbac\Service\Permission;
+use Common\Service\Helper\FlashMessengerHelperService;
+use Common\Service\Helper\FormHelperService;
+use Common\Service\Helper\TranslationHelperService;
 use Dvsa\Olcs\Transfer\Command\Irfo\ApproveIrfoGvPermit as ApproveDto;
 use Dvsa\Olcs\Transfer\Command\Irfo\CreateIrfoGvPermit as CreateDto;
 use Dvsa\Olcs\Transfer\Command\Irfo\GenerateIrfoGvPermit as GenerateDto;
@@ -10,6 +14,7 @@
 use Dvsa\Olcs\Transfer\Command\Irfo\WithdrawIrfoGvPermit as WithdrawDto;
 use Dvsa\Olcs\Transfer\Query\Irfo\IrfoGvPermit as ItemDto;
 use Dvsa\Olcs\Transfer\Query\Irfo\IrfoGvPermitList as ListDto;
+use Laminas\Navigation\Navigation;
 use Laminas\View\Model\ViewModel;
 use Olcs\Controller\AbstractInternalController;
 use Olcs\Controller\Interfaces\LeftViewProvider;
@@ -47,6 +52,19 @@ class OperatorIrfoGvPermitsController extends AbstractInternalController impleme
     protected $tableName = 'operator.irfo.gv-permits';
     protected $listDto = ListDto::class;
     protected $listVars = ['organisation'];
+    private Permission $permissionService;
+
+
+    public function __construct(
+        TranslationHelperService $translationHelperService,
+        FormHelperService $formHelperService,
+        FlashMessengerHelperService $flashMessengerHelperService,
+        Navigation $navigation,
+        Permission $permissionService
+    ) {
+        $this->permissionService = $permissionService;
+        parent::__construct($translationHelperService, $formHelperService, $flashMessengerHelperService, $navigation);
+    }
 
     /**
      * get Method leftView
@@ -99,6 +117,12 @@ public function getLeftView()
         'irfoPermitStatus' => 'irfo_perm_s_pending'
     ];
 
+    public function detailsAction()
+    {
+        $this->placeholder()->setPlaceholder('isInternalReadOnly', $this->permissionService->isInternalReadOnly());
+        return parent::detailsAction();
+    }
+
     /**
      * not found action
      *

diff --git a/app/internal/module/Olcs/src/Controller/Operator/OperatorIrfoGvPermitsControllerFactory.php b/app/internal/module/Olcs/src/Controller/Operator/OperatorIrfoGvPermitsControllerFactory.php
@@ -2,6 +2,7 @@
 
 namespace Olcs\Controller\Operator;
 
+use Common\Rbac\Service\Permission;
 use Common\Service\Helper\FlashMessengerHelperService;
 use Common\Service\Helper\FormHelperService;
 use Common\Service\Helper\TranslationHelperService;
@@ -25,11 +26,14 @@ public function __invoke(ContainerInterface $container, $requestedName, array $o
         $navigation = $container->get('navigation');
         assert($navigation instanceof Navigation);
 
+        $permissionService = $container->get(Permission::class);
+
         return new OperatorIrfoGvPermitsController(
             $translationHelper,
             $formHelper,
             $flashMessenger,
-            $navigation
+            $navigation,
+            $permissionService
         );
     }
 }
diff --git a/app/internal/module/Olcs/view/sections/operator/pages/irfo-gv-permit.phtml b/app/internal/module/Olcs/view/sections/operator/pages/irfo-gv-permit.phtml
@@ -1,38 +1,42 @@
 <?php
 $entity = $this->placeholder('details')->getValue();
+$isInternalReadOnly = $this->placeholder('isInternalReadOnly')->getValue();
 
 $actions = [];
-if ($entity['isApprovable']) {
-    $actions[] = [
-        'url' => $this->url(null, ['action' => 'approve'], [], true),
-        'label' => 'Approve',
-        'class' => 'govuk-button'
-    ];
-}
-if ($entity['isGeneratable']) {
-    $actions[] = [
-        'url' => $this->url(null, ['action' => 'generate'], [], true),
-        'label' => 'Generate',
-        'class' => 'govuk-button'
-    ];
-}
-if ($entity['irfoPermitStatus']['id'] === 'irfo_perm_s_pending') {
-    $actions[] = [
-        'url' => $this->url(null, ['action' => 'withdraw'], [], true),
-        'label' => 'Withdraw',
-        'class' => 'govuk-button govuk-button--secondary'
-    ];
-    $actions[] = [
-        'url' => $this->url(null, ['action' => 'refuse'], [], true),
-        'label' => 'Refuse',
-        'class' => 'govuk-button govuk-button--secondary'
-    ];
-} else {
-    $actions[] = [
-        'url' => $this->url(null, ['action' => 'reset'], [], true),
-        'label' => 'Reset',
-        'class' => 'govuk-button govuk-button--secondary'
-    ];
+
+if (!$isInternalReadOnly) {
+    if ($entity['isApprovable']) {
+        $actions[] = [
+            'url' => $this->url(null, ['action' => 'approve'], [], true),
+            'label' => 'Approve',
+            'class' => 'govuk-button',
+        ];
+    }
+    if ($entity['isGeneratable']) {
+        $actions[] = [
+            'url' => $this->url(null, ['action' => 'generate'], [], true),
+            'label' => 'Generate',
+            'class' => 'govuk-button',
+        ];
+    }
+    if ($entity['irfoPermitStatus']['id'] === 'irfo_perm_s_pending') {
+        $actions[] = [
+            'url' => $this->url(null, ['action' => 'withdraw'], [], true),
+            'label' => 'Withdraw',
+            'class' => 'govuk-button govuk-button--secondary',
+        ];
+        $actions[] = [
+            'url' => $this->url(null, ['action' => 'refuse'], [], true),
+            'label' => 'Refuse',
+            'class' => 'govuk-button govuk-button--secondary',
+        ];
+    } else {
+        $actions[] = [
+            'url' => $this->url(null, ['action' => 'reset'], [], true),
+            'label' => 'Reset',
+            'class' => 'govuk-button govuk-button--secondary',
+        ];
+    }
 }
 
 echo $this->render('partials/read-only/main',