fix: companies house code now checks insolvency flag properly (dvsa/o…

…lcs-backend#164)
dvsa · May 7, 2024 · 4e93a92 · 4e93a92
1 parent 5351e52
commit 4e93a92
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/app/api/module/Api/src/Domain/CommandHandler/CompaniesHouse/Compare.php b/app/api/module/Api/src/Domain/CommandHandler/CompaniesHouse/Compare.php
@@ -30,6 +30,8 @@ final class Compare extends AbstractCommandHandler
      */
     public function handleCommand(CommandInterface $command)
     {
+        $this->result->setFlag('isInsolvent', false);
+
         $companyNumber = $command->getCompanyNumber();
 
         try {

diff --git a/...ule/Cli/src/Domain/CommandHandler/MessageQueue/Consumer/CompaniesHouse/CompanyProfile.php b/...ule/Cli/src/Domain/CommandHandler/MessageQueue/Consumer/CompaniesHouse/CompanyProfile.php
@@ -29,12 +29,13 @@ public function handleCommand(CommandInterface $command)
         }
 
         $companyNumber = $messages[0]['Body'];
-        $this->result->merge($this->handleSideEffect(Compare::create(['companyNumber' => $companyNumber])));
+        $companyResult = $this->handleSideEffect(Compare::create(['companyNumber' => $companyNumber]));
+        $this->result->merge($companyResult);
 
         $companiesHouseCompany = $this->getRepo()->getLatestByCompanyNumber($companyNumber);
         $isProcessed = $companiesHouseCompany->getInsolvencyProcessed();
 
-        if ($this->result->getFlag('isInsolvent') && !$isProcessed) {
+        if ($companyResult->getFlag('isInsolvent') === true && !$isProcessed) {
             $insolvencyMessage = $this->messageBuilderService->buildMessage(
                 ['companyOrLlpNo' => $companyNumber],
                 ProcessInsolvency::class,