Fix: VOL-4687 - Refactor ListConversation Query for compatibility with internal (applications) #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fibble
approved these changes
Dec 11, 2023
Jamie-Gordon-1
requested review from
Jamie-Gordon-1
and removed request for
Jamie-Gordon-1
Jamie-Gordon-1
approved these changes
Dec 11, 2023
jerotire
added a commit
that referenced
this pull request
Dec 11, 2023
…h internal (applications) (#5) * Refactor query for compatibility with applications * Unit Tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors the ListConversation query splitting into 2 seperate queries which are handled differently on olcs-backend. Supports looking up a licence from a given application, and providing a list of conversations for that licence (from the given application).
Related issue: VOL-4687
Before submitting (or marking as "ready for review")