Skip to content
This repository has been archived by the owner on Aug 16, 2024. It is now read-only.

fix: update header SVG as the vector now contains the logo text #176

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

fibble
Copy link
Contributor

@fibble fibble commented Aug 6, 2024

Description

Update Header SVG as it now includes the text and crest.

Related issue: VOL-5693

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

@fibble fibble changed the title fix: update header SVG as the vector now contains the text as well as… fix: update header SVG as the vector now contains the logo text Aug 6, 2024
Copy link
Contributor

@JoshuaLicense JoshuaLicense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Small tweak to the link

module/Olcs/view/layouts/base.phtml Outdated Show resolved Hide resolved
Co-authored-by: JoshuaLicense <JoshuaLicense@users.noreply.github.com>
@fibble fibble merged commit 53de0ca into main Aug 6, 2024
8 checks passed
@fibble fibble deleted the govuk-logo-style-changed-vol-5693 branch August 6, 2024 18:31
jerotire pushed a commit to dvsa/vol-app that referenced this pull request Aug 16, 2024
…/olcs-selfserve#176)

* fix: update header SVG as the vector now contains the text as well as the logo.

* Update module/Olcs/view/layouts/base.phtml

Co-authored-by: JoshuaLicense <JoshuaLicense@users.noreply.github.com>

---------

Co-authored-by: JoshuaLicense <JoshuaLicense@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants