Skip to content
This repository has been archived by the owner on Aug 16, 2024. It is now read-only.

fix: doctype not being output in several places #200

Merged
merged 2 commits into from
Jul 29, 2024
Merged

fix: doctype not being output in several places #200

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d07eef9
fix: doctype not actually being output in several places.
fibble Jul 19, 2024
48927d3
fix: remove test CDN deps
fibble Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion module/Olcs/view/layout/base.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
}

}
$this->doctype(); ?>
echo $this->doctype(); ?>

<html lang="en">
<head>
Expand Down
4 changes: 3 additions & 1 deletion module/Olcs/view/layout/signin.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
<?php
$this->doctype();
echo $this->doctype().PHP_EOL;

// OLCS-26896 - make sure X-UA-Compatible value is not escaped on the internal login screen
$this->headMeta()->setAutoEscape(false);
?>
<html lang="en">
<head>
<?php echo $this->partial('partials/head', ['title' => $this->pageTitle()]); ?>
<script src="https://code.jquery.com/jquery-3.6.0.min.js"></script>
<script src="https://code.jquery.com/jquery-migrate-3.3.2.min.js"></script>
JoshuaLicense marked this conversation as resolved.
Show resolved Hide resolved
</head>
<body class="internal sign-in" id="<?php echo $this->pageId(); ?>">
<?php echo $this->version(); ?>
Expand Down
2 changes: 1 addition & 1 deletion module/Olcs/view/layout/simple.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,4 @@
</div>

</body>
</html>
</html>
Loading