Skip to content
This repository has been archived by the owner on Aug 16, 2024. It is now read-only.

feat: LTA Admin edit functionality #194

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Conversation

fibble
Copy link
Contributor

@fibble fibble commented Jun 21, 2024

Description

Local Authority Admin Edit Functionality

Related issue: VOL-5532

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

Copy link
Contributor

@jerotire jerotire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me in general; however do we need any tests for this PR? Quite a few additions with no additional tests.

module/Admin/config/navigation.config.php Outdated Show resolved Hide resolved
@fibble fibble force-pushed the lta-admin-functtion-vol-5532 branch from c5c91ba to 6279b39 Compare June 26, 2024 14:14
@fibble fibble force-pushed the lta-admin-functtion-vol-5532 branch from 5fd8bdc to 0a48717 Compare June 28, 2024 09:59
@fibble fibble requested a review from ilindsay June 28, 2024 14:18
@ilindsay ilindsay merged commit 3cf7cca into main Jul 1, 2024
6 checks passed
@ilindsay ilindsay deleted the lta-admin-functtion-vol-5532 branch July 1, 2024 10:25
jerotire pushed a commit to dvsa/vol-app that referenced this pull request Aug 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants