This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fibble
force-pushed
the
support-php-8.2-vol-4766
branch
from
May 13, 2024 13:09
0b0e940
to
201766c
Compare
fibble
changed the title
feat: Support php 8.2 vol 4766
feat!: Support php 8.2 vol 4766
May 13, 2024
JoshuaLicense
suggested changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, few suggestions left.
Co-authored-by: JoshuaLicense <JoshuaLicense@users.noreply.github.com>
…upport-php-8.2-vol-4766
ilindsay
approved these changes
May 14, 2024
JoshuaLicense
approved these changes
May 15, 2024
jerotire
pushed a commit
to dvsa/vol-app
that referenced
this pull request
Aug 16, 2024
* feat: Update to support php 8.2 * feat: Update to support php ^8.2 * feat!: reset phpunit execution order to random. * feat!: delete rector.php util file * Update composer.json Co-authored-by: JoshuaLicense <JoshuaLicense@users.noreply.github.com> * feat!: delete rector dependency * feat!: delete rector dependency --------- Co-authored-by: JoshuaLicense <JoshuaLicense@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PHP ^8.2 support
Related issue: VOL-4766
Breaking Change - requires new minimum PHP Version.
Before submitting (or marking as "ready for review")