Skip to content
This repository has been archived by the owner on Aug 16, 2024. It is now read-only.

feat!: Support php 8.2 vol 4766 #165

Merged
merged 8 commits into from
May 15, 2024
Merged

Conversation

fibble
Copy link
Contributor

@fibble fibble commented May 13, 2024

Description

PHP ^8.2 support

Related issue: VOL-4766

Breaking Change - requires new minimum PHP Version.

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

@fibble fibble changed the title feat: Support php 8.2 vol 4766 feat!: Support php 8.2 vol 4766 May 13, 2024
Copy link
Contributor

@JoshuaLicense JoshuaLicense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, few suggestions left.

composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
fibble and others added 3 commits May 13, 2024 14:21
Co-authored-by: JoshuaLicense <JoshuaLicense@users.noreply.github.com>
@fibble fibble requested a review from JoshuaLicense May 13, 2024 13:24
composer.lock Outdated Show resolved Hide resolved
@fibble fibble requested a review from JoshuaLicense May 15, 2024 08:00
@JoshuaLicense JoshuaLicense merged commit 00553f4 into main May 15, 2024
6 checks passed
@JoshuaLicense JoshuaLicense deleted the support-php-8.2-vol-4766 branch May 15, 2024 08:52
jerotire pushed a commit to dvsa/vol-app that referenced this pull request Aug 16, 2024
* feat: Update to support php 8.2

* feat: Update to support php ^8.2

* feat!: reset phpunit execution order to random.

* feat!: delete rector.php util file

* Update composer.json

Co-authored-by: JoshuaLicense <JoshuaLicense@users.noreply.github.com>

* feat!: delete rector dependency

* feat!: delete rector dependency

---------

Co-authored-by: JoshuaLicense <JoshuaLicense@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants