This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
fix: Messaging error/validation messages #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wadedvsa
previously approved these changes
Mar 27, 2024
This reverts commit a7287c0.
wadedvsa
approved these changes
Mar 28, 2024
fibble
approved these changes
Mar 28, 2024
jerotire
pushed a commit
to dvsa/vol-app
that referenced
this pull request
Aug 16, 2024
* feat: Use custom messages for messaging when defined * chore: Use annotations to configure validation messages * Add messages with priority * Add length and label * fix: Bad annotation * Revert "fix: Bad annotation" This reverts commit a7287c0fe90fe1917d8c98c8bf724b8ecded150e. * fix: Bad annotation --------- Co-authored-by: Saul Wilcox <saul.wilcox@dvsa.gov.uk>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow up to address an inconsitency between text inputs on internal vs selfserve
Related issue: VOL-5003
Before submitting (or marking as "ready for review")