fix: Translation popup showing HTML rather then rendering (#133)

* fix: Translation popup showing HTML rather then rendering * chore: Exclude CSS/JS from PHPCS * fix: Update phpcs.xml.dist Co-authored-by: JoshuaLicense <JoshuaLicense@users.noreply.github.com> * fix: remove unused args * fix: Accidental line removal --------- Co-authored-by: JoshuaLicense <JoshuaLicense@users.noreply.github.com>
dvsa · Mar 27, 2024 · 235e61f · 235e61f
1 parent abd5b1a
commit 235e61f
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 10 deletions.
diff --git a/module/Admin/assets/js/inline/forms/translation-key-modal.js b/module/Admin/assets/js/inline/forms/translation-key-modal.js
@@ -25,20 +25,22 @@ $(function () {
             var current = " current";
             $.each(result.languages, function (idx, lang) {
                     var hideClass = (idx === "en_GB") ? "" : " js-hidden";
-                    var tabTemplate =
-                        ` < li id = "tab{idx}" class = "horizontal-navigation__item transKeyTab${current}" data - lang = "${idx}" style = "padding: 0px; margin: 0px;" >
-                            < a class = "govuk-link" id = "transKeyEnGB" href = "#" > ${lang.label} < / a >
-                       <  / li > `;
-                    var textAreaTemplate =
-                        ` < div class = "langFields field ${hideClass}" >
-                                < textarea name = "fields[translationsArray][${idx}]" id = "input-${idx}" class = "extra-long" > < / textarea >
-                        <  / div > `;
+                    var tabTemplate = `
+                        <li id="tab{idx}" class="horizontal-navigation__item transKeyTab${current}" data-lang="${idx}" style="padding: 0px; margin: 0px;">
+                            <a class="govuk-link" id="transKeyEnGB" href="#">${lang.label}</a>
+                       </li>
+                    `;
+                    var textAreaTemplate = `
+                        <div class="langFields field ${hideClass}">
+                                <textarea name="fields[translationsArray][${idx}]" id="input-${idx}" class="extra-long"></textarea>
+                        </div>
+                    `;
                     $("#languageTabs").append(tabTemplate);
                     fieldset.prepend(textAreaTemplate);
                     current = "";
             });
             fieldset.removeClass("hidden");
-            if (addedit == "edit") {
+            if (addedit === "edit") {
                 getTranslatedText();
             } else {
                 $("#mainForm").removeClass("js-hidden");

diff --git a/phpcs.xml.dist b/phpcs.xml.dist
@@ -5,7 +5,7 @@
   <file>./config</file>
   <file>./test</file>
 
-  <extensions>php</extensions>
+  <arg name="extensions" value="php" />
   <exclude-pattern>*/vendor/*</exclude-pattern>
 
   <rule ref="./vendor-bin/phpcs/vendor/dvsa/coding-standards/src/Profiles/DVSA/CS/ruleset.xml" />