Skip to content
This repository has been archived by the owner on Aug 16, 2024. It is now read-only.

fix: Slow join on documents to messages. #95

Merged
merged 2 commits into from
Mar 6, 2024
Merged

fix: Slow join on documents to messages. #95

merged 2 commits into from
Mar 6, 2024

Conversation

wadedvsa
Copy link
Contributor

@wadedvsa wadedvsa commented Mar 5, 2024

Description

Use both conversation and message on join to avoid lack of index use (MySQL not picking conversation index).

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

jerotire
jerotire previously approved these changes Mar 5, 2024
View reviewed changes
@wadedvsa wadedvsa merged commit 2e14f69 into main Mar 6, 2024
6 checks passed
@wadedvsa wadedvsa deleted the bugfix/slow-join-on-message-documents branch March 6, 2024 09:40
@github-actions github-actions bot mentioned this pull request Mar 5, 2024
Open
jerotire pushed a commit to dvsa/vol-app that referenced this pull request Aug 16, 2024
@wadedvsa
fix: Slow join on documents to messages. (dvsa/olcs-backend#95)
43b1347 
* fix: Slow join on documents to messages.

* chore: Typing
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hobbyhacker0 hobbyhacker0 hobbyhacker0 approved these changes

@jerotire jerotire jerotire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wadedvsa @hobbyhacker0 @jerotire