Skip to content
This repository has been archived by the owner on Aug 16, 2024. It is now read-only.

feat: Automatically close tasks when conversation closed #115

Merged
merged 1 commit into from
Mar 19, 2024
Merged

feat: Automatically close tasks when conversation closed #115

merged 1 commit into from
Mar 19, 2024

Conversation

jerotire
Copy link
Contributor

@jerotire jerotire commented Mar 18, 2024 •
edited
Loading

Description

  • Automatically close the conversations corrisponding task when a conversation is closed.
  • Some basic refactoring.
  • Added missing unit test coverate for Close command.

Related issue: https://dvsa.atlassian.net/browse/VOL-5152

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

@jerotire jerotire changed the title feat: Automatically closed tasks when conversation closed feat: Automatically close tasks when conversation closed Mar 18, 2024
@jerotire jerotire marked this pull request as ready for review March 18, 2024 16:18
@jerotire jerotire merged commit 320f0fb into main Mar 19, 2024
6 checks passed
@jerotire jerotire deleted the feature/VOL-5152 branch March 19, 2024 09:30
@github-actions github-actions bot mentioned this pull request Mar 18, 2024
Open
jerotire added a commit to dvsa/vol-app that referenced this pull request Aug 16, 2024
@jerotire
feat: Automatically closed tasks when conversation closed (dvsa/olcs-…
6a2a640 
…backend#115)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hobbyhacker0 hobbyhacker0 hobbyhacker0 approved these changes

@wadedvsa wadedvsa wadedvsa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jerotire @hobbyhacker0 @wadedvsa