fix: remove array walk (#213)

* fix: remove array walk * fix: removed test
dvsa · Aug 13, 2024 · 5980240 · 5980240
1 parent 1ebbded
commit 5980240
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 7 deletions.
diff --git a/module/Api/src/Domain/QueryHandler/Messaging/Conversations/ByApplicationToLicence.php b/module/Api/src/Domain/QueryHandler/Messaging/Conversations/ByApplicationToLicence.php
@@ -32,12 +32,7 @@ public function handleQuery(QueryInterface $query)
             'licence'  => $application->getLicence()->getId(),
             'statuses' => $query->getStatuses(),
         ];
-        $byLicence = $this->getQueryHandler()->handleQuery(GetConversationsByLicenceQuery::create($licenceQuery));
-        array_walk(
-            $byLicence['result'],
-            fn(&$result) => $result['task']['application'] = $application->serialize(),
-        );
 
-        return $byLicence;
+        return $this->getQueryHandler()->handleQuery(GetConversationsByLicenceQuery::create($licenceQuery));
     }
 }
diff --git a/...module/Api/src/Domain/QueryHandler/Messaging/Conversations/ByApplicationToLicenceTest.php b/...module/Api/src/Domain/QueryHandler/Messaging/Conversations/ByApplicationToLicenceTest.php
@@ -33,7 +33,6 @@ public function testHandleQuery()
         $mockLicence->shouldReceive('getId')->once()->andReturn(2);
         $mockApplication = m::mock(Application::class);
         $mockApplication->shouldReceive('getLicence')->once()->andReturn($mockLicence);
-        $mockApplication->shouldReceive('serialize')->once()->andReturn(['id' => 7]);
 
         $this->repoMap[Repository\Application::class]->shouldReceive('fetchById')->andReturn($mockApplication);