fix: increase PHP static analysis level (#5)

* fix: bump static analysis level

* fix: bump Psalm and include tests

* build: bump devcontainer to PHP8.2

* ci: bump Psalm error level to 5

* !fixup

.devcontainer/devcontainer.json

@@ -2,7 +2,7 @@
   "image": "mcr.microsoft.com/devcontainers/base:ubuntu-22.04",
   "features": {
     "ghcr.io/devcontainers/features/php:1": {
-      "version": "8.0"
+      "version": "8.2"
     }
   },
   "containerEnv": {

phpstan.neon

@@ -1,5 +1,5 @@
 parameters:
-  level: 4
+  level: 7
   paths:
     - src
     - test

psalm.xml

@@ -1,6 +1,6 @@
 <?xml version="1.0"?>
 <psalm
-  errorLevel="7"
+  errorLevel="5"
   resolveFromConfigFile="true"
   xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
   xmlns="https://getpsalm.org/schema/config"
@@ -10,6 +10,7 @@
 >
   <projectFiles>
     <directory name="src"/>
+    <directory name="test"/>
     <ignoreFiles>
       <directory name="vendor"/>
     </ignoreFiles>

src/Module.php

@@ -42,7 +42,7 @@ public function onMergeConfig(ModuleEvent $e): void
 
             $provider = $fqcn::create($config);
 
-            $parameters = array_merge($parameters, ...array_map(fn($id) => $provider($id), $ids));
+            $parameters = array_merge($parameters, ...array_map(fn(string $id) => $provider($id), $ids));
         }
 
         $bag = new ParameterBag($parameters);
@@ -66,6 +66,8 @@ public function onMergeConfig(ModuleEvent $e): void
 
     /**
      * @return array<string, mixed>
+     *
+     * @psalm-return array{config_parameters: array{providers: array<string, string[]>}}
      */
     public function getConfig(): array
     {

test/Functional/ModuleTest.php

@@ -14,6 +14,9 @@
 use Laminas\ServiceManager\ServiceManager;
 use PHPUnit\Framework\TestCase;
 
+/**
+ * @psalm-api
+ */
 class ModuleTest extends TestCase
 {
     public function testProcessParameters(): void
@@ -60,8 +63,8 @@ public function testProcessParameters(): void
 
         $config = $application->getConfig();
 
-        $this->assertEquals('secret', $config['secret']);
-        $this->assertEquals('parameter', $config['parameter']);
+        $this->assertEquals('secret', $config['secret'] ?? null);
+        $this->assertEquals('parameter', $config['parameter'] ?? null);
     }
 
     public function testMissingParametersThrowException(): void
@@ -96,6 +99,9 @@ public function testMissingParametersThrowException(): void
         $application->getConfig();
     }
 
+    /**
+     * @param array<string, mixed> $moduleConfig
+     */
     protected function createApplication(array $moduleConfig): Application
     {
         $configuration = [

test/Unit/ParameterProvider/Aws/ParameterStoreTest.php

@@ -9,6 +9,9 @@
 use Dvsa\LaminasConfigCloudParameters\ParameterProvider\Aws\ParameterStore;
 use PHPUnit\Framework\TestCase;
 
+/**
+ * @psalm-api
+ */
 class ParameterStoreTest extends TestCase
 {
     public function testThrowsLibraryException(): void

test/Unit/ParameterProvider/Aws/SecretsManagerTest.php

@@ -9,6 +9,9 @@
 use Dvsa\LaminasConfigCloudParameters\ParameterProvider\Aws\SecretsManager;
 use PHPUnit\Framework\TestCase;
 
+/**
+ * @psalm-api
+ */
 class SecretsManagerTest extends TestCase
 {
     public function testThrowsLibraryException(): void