fixed the config injection for s3

dvsa · Oct 3, 2024 · 300f8ce · 300f8ce
1 parent 3dbac3d
commit 300f8ce
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/config/DependencyInjection.ts b/src/config/DependencyInjection.ts
@@ -2,16 +2,17 @@ import { LambdaClient } from '@aws-sdk/client-lambda';
 import { S3Client } from '@aws-sdk/client-s3';
 import * as AWSXRay from 'aws-xray-sdk';
 import { Container, Service } from 'typedi';
-import { IInvokeConfig } from '../models';
+import { IInvokeConfig, IS3Config } from '../models';
 import { Configuration } from '../utils/Configuration';
 
 @Service()
 export class DependencyInjection {
 	public static register() {
-		const config: IInvokeConfig = Configuration.getInstance().getInvokeConfig();
+		const invokeConfig: IInvokeConfig = Configuration.getInstance().getInvokeConfig();
+		const s3Config: IS3Config = Configuration.getInstance().getS3Config();
 
-		Container.set(LambdaClient, AWSXRay.captureAWSv3Client(new LambdaClient(config.params)));
-		Container.set(S3Client, AWSXRay.captureAWSv3Client(new S3Client(config)));
+		Container.set(LambdaClient, AWSXRay.captureAWSv3Client(new LambdaClient(invokeConfig.params)));
+		Container.set(S3Client, AWSXRay.captureAWSv3Client(new S3Client(s3Config)));
 
 		const isOffline = (process.env.IS_OFFLINE ?? false) as boolean;
 		if (isOffline) {

diff --git a/src/functions/CertificateRequestProcessor.ts b/src/functions/CertificateRequestProcessor.ts
@@ -3,7 +3,7 @@ import { Service } from 'typedi';
 import { validate as uuidValidate } from 'uuid';
 import { ITestResult } from '../models';
 import { ERRORS, TEST_RESULT_STATUS } from '../models/Enums';
-import { CertificateGenerationService, IGeneratedCertificateResponse } from '../services/CertificateGenerationService';
+import { CertificateGenerationService } from '../services/CertificateGenerationService';
 import { CertificateUploadService } from '../services/CertificateUploadService';
 
 export type CertGenReturn = PutObjectCommandOutput | DeleteObjectCommandOutput;