Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move settings to SolidJS #72

Merged
merged 70 commits into from
May 9, 2023
Merged

Move settings to SolidJS #72

merged 70 commits into from
May 9, 2023

Conversation

dvdvdmt
Copy link
Owner

@dvdvdmt dvdvdmt commented Mar 16, 2023

Replace Vue with Solid to unify the codebase.

@dvdvdmt dvdvdmt self-assigned this Mar 16, 2023
dvdvdmt added 27 commits March 25, 2023 08:55
@dvdvdmt
Place all deps in one field.
b694f05 
It is because the extension can't be released as a package to NPM and should only be consumed through the archive or Chrome Web Store
@dvdvdmt
Disable the switching to another page when the settings are opened du…
2334aa7 
…ring the migration to SolidJs.
@dvdvdmt
Place Solid root near the Vue's one
8c68365
@dvdvdmt
Render SolidJS alongside the Vue.
0cb3591
@dvdvdmt
Setup CSS modules approach for the settings page.
968e3f0
@dvdvdmt
Pass initial settings object to component.
b11a742
@dvdvdmt
Move solid-js related code into one folder
4a7848a
@dvdvdmt
Partially migrate the tabs component
9abc426
@dvdvdmt
Enable effects on tabs component
9ad8c9f
@dvdvdmt
Move tab-bar to components
ef56261
@dvdvdmt
Create a separate settings-form component
b98d5f0
@dvdvdmt
Show banner if the shortcuts are not set
6e57d44
@dvdvdmt
Migrate banner component from Vue
717176c
@dvdvdmt
Preserve original names of nested classes using the :global scope
472d238
@dvdvdmt
Improve banner styles
e68d77d
@dvdvdmt
Open the keyboard shortcuts page and focus the extension
e0113fb
@dvdvdmt
Migrate dark mode toggle
304c92a
@dvdvdmt
Migrate text field component
593d25c
@dvdvdmt
Left TODO
5b27e94
@dvdvdmt
React on changes in number inputs and save the settings
a06e77a
@dvdvdmt
Fix partial update in the Settings Service
3342e84
@dvdvdmt
Normalize the number input and make it more convenient to use
6622597
@dvdvdmt
Migrate the rest of the form elements
2ed182a
@dvdvdmt
Restore default settings
8ea2199
@dvdvdmt
Left a note about logger
fd35993
@dvdvdmt
Start migration of Contribute section
deb313b
@dvdvdmt
Migrate Copy link button
061a7af
dvdvdmt added 28 commits April 16, 2023 11:54
@dvdvdmt
Move all global CSS files into single place
d231f17
@dvdvdmt
Remove most of the deps on the material mixings and make the styling …
3858ce9 
…less dependant
@dvdvdmt
Reuse button component in banner
dbe9666
@dvdvdmt
Make styles of the input to follow CSS-module convention
668afa7
@dvdvdmt
Left a note about composing from global styles
b43e558
@dvdvdmt
Clean up text-field from explicit imports of global styles and replace …
2720d43 
…@extend with CSS-modules compose:
@dvdvdmt
Clean up the button component from explicit imports of global styles …
b49291f 
…and replace "@extend" with CSS-modules "compose"
@dvdvdmt
Move .materialIcon to global styles
31ef9ff
@dvdvdmt
Clean up the banner component from explicit imports of global styles …
329c584 
…and replace "@extend" with CSS-modules "compose"
@dvdvdmt
Clean up the Contribute component from explicit imports of global sty…
f05bfe6 
…les and replace "@extend" with CSS-modules "compose"
@dvdvdmt
Clean up the Settings component from explicit imports of global style…
9eebb9d 
…s and replace "@extend" with CSS-modules "compose"
@dvdvdmt
Remove the dependency on @Material SCSS and move all the necessary th…
3c3bfdc 
…ings into file to build the color scheme
@dvdvdmt
Fix copy link button
5c8d575
@dvdvdmt
Fix all sharing options
c10d2ce
@dvdvdmt
Add a note about the bug
106f16d
@dvdvdmt
Replace Vue to Solid in settings app
8335540
@dvdvdmt
Remove Vue from the project
85d9783
@dvdvdmt
Run build before running e2e tests always
2b2709c
@dvdvdmt
Fix invalid checked state
82e3aef
@dvdvdmt
Prepare background script to recieving settings from the settings page
c8e266d
@dvdvdmt
Fix the rest of the tests
9ed04ec
@dvdvdmt
Use selector instead of concrete value
2754cf2
@dvdvdmt
Demo settings on extension button click
cb23457
@dvdvdmt
Remove the rest of the Vue
5ffbd70
@dvdvdmt
Remove unused dependency
65b841e
@dvdvdmt
Update version
8523c55
@dvdvdmt
Update puppeteer
51d6a92
@dvdvdmt
Turn off couple of tests in CI
c3dfd41
@dvdvdmt dvdvdmt merged commit caca13b into master May 9, 2023
@dvdvdmt dvdvdmt deleted the move-settings-to-solid-js branch May 9, 2023 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dvdvdmt dvdvdmt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dvdvdmt