Visual tests #71
Merged
Visual tests #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore all diff and current screenshots.
…ension programmatically
…kground script. To address parent window we use 'window.parent' in sendMessage function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Goal
Settings page should be migrated from Vue to SolidJS. The migration should not break anything that is related to the look and feel of the settings page.
Problem
There are no visual tests in the project that may guarantee that everything looks the same as it is now.
Solution
This changes add a set of visual tests that will guarantee that content script and settings page will look the same after the transition.
Additional changes