Moving to SolidJs #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is no longer reproduced
…by a third party script
Make the key and other events tracking more reliable by placing handling them on capture phase
Now the tab switcher removes all its inner the content from the DOM when it is not visible.
Now the "Selection restoration" has its own test suit.
dvdvdmt
force-pushed
the
moving-to-solidjs
branch
from
44d1885 to
5a5f0ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is time to make the switcher more efficient and maintainable. SolidJS framework showed itself as a great combination of the best practices from React like JSX, functional components, beautiful reactivity model (updating the view based on changes in state) and efficient DOM updates without any virtual DOM penalty.