Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docs and param name in serializer to fit changes in ED 1.0.0-Bet... #74

Merged
merged 1 commit into from
Feb 23, 2015

Conversation

holandes22
Copy link
Collaborator

...a.15

- Latest Ember Data added a snapshot API, which is
  passed to the serializer instead of the record instance
  http://emberjs.com/blog/2015/02/14/ember-data-1-0-beta-15-released.html

…Beta.15

    - Latest Ember Data added a snapshot API, which is
      passed to the serializer instead of the record instance
      http://emberjs.com/blog/2015/02/14/ember-data-1-0-beta-15-released.html
@dustinfarris
Copy link
Owner

Thanks for updating this.

dustinfarris added a commit that referenced this pull request Feb 23, 2015
Updated docs and param name in serializer to fit changes in ED 1.0.0-Bet...
@dustinfarris dustinfarris merged commit c82d3f6 into dustinfarris:master Feb 23, 2015
@benkonrath
Copy link
Collaborator

Thanks! Does this make us require Ember Data 1.0 beta 15 as a minimum version?

@dustinfarris
Copy link
Owner

This commit doesn't seem to—it's more semantics—but I'm thinking our next release will be 0.6.0 which will require ember-cli 0.2.0 (once it is out of beta) and ED beta 15.

@holandes22
Copy link
Collaborator Author

Thanks for the merge.

@benkonrath it is as @dustinfarris says, just a semantic change, no real dependency on version beta 15 since we don't actually use the param, we just pass it along.

I tested it with beta15 before the change and it also worked perfectly.

BTW, did you guys upgrade to latest ember data in your projects yet? Just wandering if you encounter any issues with the adapter (I didn't)

@benkonrath
Copy link
Collaborator

I haven't been using ember much lately so I haven't updated my apps yet. I'm planning to update when I continue with work my projects that use ember.

@dustinfarris
Copy link
Owner

I've been tracking ember-cli's default app blueprint dependencies. As of their latest stable (0.1.15), that's ED beta.14.1.

I am very excited about and looking forward to the 0.2.0 release of ember-cli which will peg ED beta.15 and Ember 1.10.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants