Add a test for embedded belongsTo create with id. #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is #115 related? |
|
or, more specifically, emberjs/data#3360 |
|
It didn't work with EDA 0.5.6 / ED 1.0.0-beta.18 as well so I suspect that it's not emberjs/data#3360. I'll have to keep digging. |
benkonrath
force-pushed
the
embedded-belongsTo-create-by-id
branch
from
a934798 to
60095cc
Compare
|
Ok, so I was just doing it wrong. You need to set the full record and it will be serialized to the id. I've updated the test and it now passes. I think it's useful to have this in the integration tests as an example of how to do this. |
|
Agreed. |
dustinfarris
added a commit
that referenced
this pull request
Jul 17, 2015
Add a test for embedded belongsTo create with id.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ids for embedded beolongsTo aren't being sent when creating a record. My interpretation is that setting
post: {serialize: 'id', deserialize: 'records'}in the serializer should allow the embedded record to work on retrieve but also allow the id to be set on create / update. The test shows that ED is sendingnullinstead of the id.I've included a couple of other cleanups / fixes in the PR. The
belongsTo createis the relevant test. Any thoughts here?