Sparkle: Adding new icons #8653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aubin-tchoi
reviewed
Nov 15, 2024
sparkle/package.json
Outdated
| @@ -112,6 +112,7 @@ | |||
| "react-confetti": "^6.1.0", | |||
| "react-dropdown-menu": "^0.0.2", | |||
| "react-markdown": "^9.0.1", | |||
| "shadcn-ui": "^0.9.3", | |||
There was a problem hiding this comment.
OOC: how come do we need this as a dependency?
There was a problem hiding this comment.
@Duncid I guess that you'll be able to answer
aubin-tchoi
reviewed
Nov 15, 2024
| @@ -0,0 +1,3 @@ | |||
| <svg width="24" height="24" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg"> | |||
There was a problem hiding this comment.
OOC: to which SVGs do we allow/disallow passing props? (I don't know much about which props are used for svg besides the color)
pinotalexandre
force-pushed
the
new-icons-2024-11
branch
from
d9a7107 to
e4b00b1
Compare
added 2 commits
November 15, 2024 14:18
JulesBelveze
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding new icons to Sparkle:
Risk
First PR for me, so maybe pay more attention in case I made any mistakes.
Deploy Plan