Poké: rework display active subscription/plan #4576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flvndvd
reviewed
Apr 4, 2024
front/pages/poke/[wId]/index.tsx
Outdated
| @@ -329,9 +328,215 @@ const WorkspacePage = ({ | |||
| </DropdownMenu.Items> | |||
| </DropdownMenu> | |||
| </div> | |||
| <div className="border-material-200 my-4 flex flex-col rounded-lg border p-4"> | |||
There was a problem hiding this comment.
😱 Can you move this to a dedicated table like we did for other tables?
There was a problem hiding this comment.
@flvndvd done, ok for you?
|
As discussed IRL I also moved the order of tables and renamed the title for the table with history of subscriptions. |
flvndvd
reviewed
Apr 5, 2024
| }) { | ||
| const activePlan = subscription.plan; | ||
| return ( | ||
| <div className="flex flex-col space-y-8 pt-4"> |
There was a problem hiding this comment.
Any chance we could factorize this? Like having an object like we do for data_table?
There was a problem hiding this comment.
Yes! Merging as is so I can focus on the new Enterprise form this morning, I'll open a new PR to handle this feedback right after 🙇🏻♀️
flvndvd
pushed a commit
that referenced
this pull request
May 26, 2024
* Poké: rework display active subscription/plan * Apply feedback * lint * Improve look
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I know this is more code but Poké deserves some love 🙈
This PR is about removing the JSON viewer to replace by a table -> splitting in both the Subscription info with the product limitations from the plan.
Next step is to move the buttons to upgrade/downgrade a workspace and add a new one for Enterprise onboarding;
Risk
/
Deploy Plan
/