Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invitation revocation sId refactor #4562

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Invitation revocation sId refactor #4562

merged 2 commits into from
Apr 4, 2024

Conversation

spolu
Copy link
Contributor

@spolu spolu commented Apr 4, 2024

Description

Move to use sId in membership invitations (revocation route). Also move the route to iots + better lib/api handling.

Risk

N/A (tested locally)

Deploy Plan

  • deploy front
  • run init_db.sh

@spolu spolu requested a review from flvndvd April 4, 2024 10:35
Copy link

github-actions bot commented Apr 4, 2024

Warnings
⚠️

Files in **/lib/models/ have been modified and the PR has the migration-ack label. Don't forget to run the migration from the -edge infrastructure.

Generated by 🚫 dangerJS against 3a1dd01

@spolu spolu added the migration-ack 📁 Label to acknowledge that a migration is required. label Apr 4, 2024
Copy link
Contributor

@flvndvd flvndvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left two small nits

id: invitation.id,
inviteEmail: invitation.inviteEmail,
status: invitation.status,
initialRole: invitation.initialRole,
};
}

export async function getInvitation({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we extract auth from the object?

return typeFromModel(invitation);
}

export async function updateInvitationStatus({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here?

@spolu spolu merged commit a412772 into main Apr 4, 2024
6 checks passed
@spolu spolu deleted the spolu-sid_routes branch April 4, 2024 10:47
flvndvd pushed a commit that referenced this pull request May 26, 2024
* Invitation revocation sId refactor

* nit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration-ack 📁 Label to acknowledge that a migration is required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants