-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invitation revocation sId refactor #4562
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left two small nits
front/lib/api/invitation.ts
Outdated
id: invitation.id, | ||
inviteEmail: invitation.inviteEmail, | ||
status: invitation.status, | ||
initialRole: invitation.initialRole, | ||
}; | ||
} | ||
|
||
export async function getInvitation({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we extract auth
from the object?
front/lib/api/invitation.ts
Outdated
return typeFromModel(invitation); | ||
} | ||
|
||
export async function updateInvitationStatus({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here?
* Invitation revocation sId refactor * nit
Description
Move to use
sId
in membership invitations (revocation route). Also move the route to iots + better lib/api handling.Risk
N/A (tested locally)
Deploy Plan
front
init_db.sh