Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add userMetadata actions to userResource #11332

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 2 additions & 25 deletions front/lib/api/user.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import { Err, Ok } from "@dust-tt/types";
import type { Authenticator } from "@app/lib/auth";
import { Workspace } from "@app/lib/models/workspace";
import { ExtensionConfigurationResource } from "@app/lib/resources/extension";
import { UserMetadataModel } from "@app/lib/resources/storage/models/user";
import { UserResource } from "@app/lib/resources/user_resource";
import { renderLightWorkspaceType } from "@app/lib/workspace";
import logger from "@app/logger/logger";
Expand Down Expand Up @@ -59,12 +58,7 @@ export async function getUserMetadata(
user: UserType,
key: string
): Promise<UserMetadataType | null> {
const metadata = await UserMetadataModel.findOne({
where: {
userId: user.id,
key,
},
});
const metadata = await UserResource.getMetadata(user.id, key);

if (!metadata) {
return null;
Expand All @@ -86,24 +80,7 @@ export async function setUserMetadata(
user: UserType,
update: UserMetadataType
): Promise<void> {
const metadata = await UserMetadataModel.findOne({
where: {
userId: user.id,
key: update.key,
},
});

if (!metadata) {
await UserMetadataModel.create({
userId: user.id,
key: update.key,
value: update.value,
});
return;
}

metadata.value = update.value;
await metadata.save();
await UserResource.setMetadata(user.id, update.key, update.value);
}

export async function fetchRevokedWorkspace(
Expand Down
54 changes: 53 additions & 1 deletion front/lib/resources/user_resource.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,10 @@ import { Op } from "sequelize";
import type { Authenticator } from "@app/lib/auth";
import { BaseResource } from "@app/lib/resources/base_resource";
import { MembershipModel } from "@app/lib/resources/storage/models/membership";
import { UserModel } from "@app/lib/resources/storage/models/user";
import {
UserMetadataModel,
UserModel,
} from "@app/lib/resources/storage/models/user";
import type { ReadonlyAttributesType } from "@app/lib/resources/storage/types";

export interface SearchMembersPaginationParams {
Expand Down Expand Up @@ -211,6 +214,55 @@ export class UserResource extends BaseResource<UserModel> {
}
}

static async getMetadata(userId: ModelId, key: string) {
return UserMetadataModel.findOne({
where: {
userId,
key,
},
});
}

static async getAllMetadata(users: ModelId[]) {
return UserMetadataModel.findAll({
where: {
userId: {
[Op.in]: users,
},
},
raw: true,
});
}

static async setMetadata(userId: ModelId, key: string, value: string) {
const metadata = await UserMetadataModel.findOne({
where: {
userId,
key,
},
});

if (!metadata) {
await UserMetadataModel.create({
userId,
key,
value,
});
return;
}

metadata.value = value;
await metadata.save();
}

static async deleteMetadata(userId: ModelId) {
return UserMetadataModel.destroy({
where: {
userId,
},
});
}

fullName(): string {
return [this.firstName, this.lastName].filter(Boolean).join(" ");
}
Expand Down
7 changes: 1 addition & 6 deletions front/poke/temporal/activities.ts
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ import {
LabsTranscriptsHistoryModel,
} from "@app/lib/resources/storage/models/labs_transcripts";
import { PlatformActionsConfigurationModel } from "@app/lib/resources/storage/models/platform_actions";
import { UserMetadataModel } from "@app/lib/resources/storage/models/user";
import { TrackerConfigurationResource } from "@app/lib/resources/tracker_resource";
import { UserResource } from "@app/lib/resources/user_resource";
import { renderLightWorkspaceType } from "@app/lib/workspace";
Expand Down Expand Up @@ -429,11 +428,7 @@ export async function deleteMembersActivity({

// If the user we're removing the membership of only has one membership, we delete the user.
if (membershipsOfUser.length === 1) {
await UserMetadataModel.destroy({
where: {
userId: user.id,
},
});
await UserResource.deleteMetadata(user.id);
hardDeleteLogger.info(
{
membershipId: membership.id,
Expand Down
17 changes: 5 additions & 12 deletions front/temporal/relocation/activities/source_region/front/sql.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,7 @@ import { getWorkspaceInfos } from "@app/lib/api/workspace";
import { Workspace } from "@app/lib/models/workspace";
import { MembershipResource } from "@app/lib/resources/membership_resource";
import { frontSequelize } from "@app/lib/resources/storage";
import {
UserMetadataModel,
UserModel,
} from "@app/lib/resources/storage/models/user";
import { UserModel } from "@app/lib/resources/storage/models/user";
import { renderLightWorkspaceType } from "@app/lib/workspace";
import logger from "@app/logger/logger";
import type {
Expand All @@ -21,6 +18,7 @@ import type {
import { writeToRelocationStorage } from "@app/temporal/relocation/lib/file_storage/relocation";
import { generateParameterizedInsertStatements } from "@app/temporal/relocation/lib/sql/insert";
import { getTopologicalOrder } from "@app/temporal/relocation/lib/sql/schema/dependencies";
import { UserResource } from "@app/lib/resources/user_resource";

export async function readCoreEntitiesFromSourceRegion({
destRegion,
Expand Down Expand Up @@ -67,14 +65,9 @@ export async function readCoreEntitiesFromSourceRegion({
});

// Fetch all associated users metadata of the workspace.
const userMetadata = await UserMetadataModel.findAll({
where: {
userId: {
[Op.in]: memberships.map((m) => m.userId),
},
},
raw: true,
});
const userMetadata = await UserResource.getAllMetadata(
memberships.map((m) => m.userId)
);

const subscriptions = await frontSequelize.query<{ planId: ModelId }>(
'SELECT * FROM subscriptions WHERE "workspaceId" = :workspaceId',
Expand Down