[front] - refactor(InputBar): attachments #11319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mline input bar attachment components - Consolidate file and node attachment handling into a single InputBarAttachments component - Remove InputBarNodeAttachments and InputBarCitations components in favor of unified attachment system - Introduce InputBarAttachmentsPicker for selecting and uploading attachments with search capabilities [front/components/assistant/conversation/input_bar/InputBarAttachmentsPicker] - feature: add input bar attachments picker for files and nodes - Implement a dropdown menu with search functionality to attach files or nodes to the input bar - Enable file uploading directly from the input bar with a new UI component for better user experience
- Add file path display and improve the tooltip information for node attachments - Include a conditional visual based on the dataSource type of attachments - Implement a Tooltip component for better clarity and information display - Refactor the attachment visual rendering logic to accommodate new features
philipperolet
approved these changes
Mar 12, 2025
front/components/assistant/conversation/input_bar/InputBarAttachments.tsx
Outdated
Show resolved
Hide resolved
front/components/assistant/conversation/input_bar/InputBarAttachments.tsx
Outdated
Show resolved
Hide resolved
…chments - Wrap the generation of fileAttachments and nodeAttachments with useMemo to optimize performance - Prevent unnecessary recalculations of attachments when props do not change
…er dropdown - Added state control to open and close the attachments picker with button click or interaction outside - Cleaned the search when closing the dropdown for a neater user experience - Auto-closing the dropdown upon node selection or file upload to streamline the UI flow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the attachments functionality in the input bar by consolidating the
InputBarCitationsandInputBarNodeAttachmentscomponents into a single unifiedInputBarAttachmentscomponent.The implementation uses a common
Citationcomponent from sparkle to display both file and knowledge attachments consistently.Risk
Low
Deploy Plan