Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep nonce validation during the key creation #136

Closed
herr-seppia opened this issue Mar 7, 2024 · 0 comments · Fixed by #142
Closed

Keep nonce validation during the key creation #136

herr-seppia opened this issue Mar 7, 2024 · 0 comments · Fixed by #142
Labels
audit

Comments

@herr-seppia
Copy link
Member

Summary

Consider change BinaryID::from_nonce to return error if nonce is not valid

Additional context

Even if the nonce is checked externally, the current code is considered error prone (because it relies on further checks to consider the BinaryID valid)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change BinaryID::from_nonce to return result dusk-network/kadcast
1 participant
@herr-seppia