-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.5.5 #25
Merged
Merged
Release v0.5.5 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Change description Adding ping of Kubernetes cluster to ensure the cached credentials are still valid for a `duplo-jit k8s` call separate from reading the expiration date. ## Type of change - [x] Bug fix (fixes an issue) - [ ] New feature (adds functionality) ## Related issues > Fix [DUPLO-9973](https://app.clickup.com/t/8655600/DUPLO-9973) - Some users report cache issues. ## Additional Notes Now using the appropriate namespace. Fixed build issues with upgrades to Go versions and GitHub action versions in the workflow configs. 1.17 -> 1.21 Added the logic to get the tenant name from the tenant ID. If necessary, I could add an optimization to cache the tenant flag as the tenant name before it is converted to a tenant ID. It would save a call to the Duplo API, but there's no benefit of course if the ID was provided in the flag in the first place. I am biasing toward simplicity for the time being on that one. Of note, I also moved the creation of the cache key for k8s creds on tenants to be performed after the name has been determined to so that the cache key for a tenant on k8s will consistently be based on the host and tenant name.
DUPLO-9973 Ensure cached AWS credentials are still valid with ping
…-ping-api DUPLO-13529 Detect token invalidation from user logout
…nt-id DUPLO-13646 Fix for obtaining K8s credential with plan ID
joek-duplo
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to update from branch release/0.5.5