Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dbus hightlight hint #862

Merged
merged 2 commits into from
May 29, 2021
Merged

Conversation

fwsmit
Copy link
Member

@fwsmit fwsmit commented May 5, 2021

Fixes #861

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2021

Codecov Report

Merging #862 (933f150) into master (b77f76f) will increase coverage by 0.00%.
The diff coverage is 62.50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #862   +/-   ##
=======================================
  Coverage   58.08%   58.09%           
=======================================
  Files          37       37           
  Lines        6101     6109    +8     
=======================================
+ Hits         3544     3549    +5     
- Misses       2557     2560    +3     
Flag Coverage Δ
unittests 58.09% <62.50%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/dbus.c 63.12% <62.50%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b77f76f...933f150. Read the comment docs.

@fwsmit
Copy link
Member Author

fwsmit commented May 28, 2021

@tsipinakis I've fixed the merge conflict for this PR.

There's still the questionable behaviour of setting the attributes before the rules are evaluated. This is problematic, because in settings refactor V2 everything is made a rule, even the [urgency_*] sections. This means that the dbus hints would not do anything, because they were overwritten by the rules. This should be fixed in c463a59

@tsipinakis tsipinakis merged commit 9f4f110 into dunst-project:master May 29, 2021
@fwsmit fwsmit deleted the dbus-highlight branch February 16, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: Progressbar ("highlight") color from hint
3 participants