Code

feat: thread autoscaling#1266

Code

Open

Alliballibaba2 wants to merge 158 commits intomaindunglas/frankenphp:mainfrom feat/auto-scale-clock-timedunglas/frankenphp:feat/auto-scale-clock-timeCopy head branch name to clipboard

+1,827-261

Commits

Commits on Nov 1, 2024

• Decouple workers.

  Alliballibaba2

  committed
  fe1158f

  Copy full SHA for fe1158f

• Moves code to separate file.

  Alliballibaba2

  committed
  ad34140

  Copy full SHA for ad34140

Commits on Nov 2, 2024

• Cleans up the exponential backoff.

  Alliballibaba2

  committed
  89b211d

  Copy full SHA for 89b211d

• Initial working implementation.

  Alliballibaba2

  committed
  7d2ab8c

  Copy full SHA for 7d2ab8c

• Refactors php threads to take callbacks.

  Alliballibaba2

  committed
  f7e7d41

  Copy full SHA for f7e7d41

• Cleanup.

  Alliballibaba2

  committed
  c03c59b

  Copy full SHA for c03c59b

• Cleanup.

  Alliballibaba2

  committed
  a9857dc

  Copy full SHA for a9857dc

• Cleanup.

  Alliballibaba2

  committed
  bac9555

  Copy full SHA for bac9555

• Cleanup.

  Alliballibaba2

  committed
  a2f8d59

  Copy full SHA for a2f8d59

Commits on Nov 3, 2024

• Merge branch 'main' into refactor/start-worker-threads-directly

  Alliballibaba2

  committed
  279924c

  Copy full SHA for 279924c

• Adjusts watcher logic.

  Alliballibaba2

  committed
  0825453

  Copy full SHA for 0825453

• Adjusts the watcher logic.

  Alliballibaba2

  committed
  17d5cbe

  Copy full SHA for 17d5cbe

Commits on Nov 4, 2024

• Fix opcache_reset race condition.

  Alliballibaba2

  committed
  09e0ca6

  Copy full SHA for 09e0ca6

• Merge branch 'main' into refactor/start-worker-threads-directly

  Show description for a726a2c
  Alliballibaba2

  committed
  a726a2c

  Copy full SHA for a726a2c

• Fixing merge conflicts and formatting.

  Alliballibaba2

  committed
  7f13ada

  Copy full SHA for 7f13ada

Commits on Nov 5, 2024

• Prevents overlapping of TSRM reservation and script execution.

  Alliballibaba2

  committed
  13fb4bb

  Copy full SHA for 13fb4bb

• Adjustments as suggested by @dunglas.

  Alliballibaba2

  committed
  a8a00c8

  Copy full SHA for a8a00c8

• Adds error assertions.

  Alliballibaba2

  committed
  b4dd138

  Copy full SHA for b4dd138

• Adds comments.

  Alliballibaba2

  committed
  03f98fa

  Copy full SHA for 03f98fa

• Removes logs and explicitly compares to C.false.

  Alliballibaba2

  committed
  e52dd0f

  Copy full SHA for e52dd0f

• Resets check.

  Alliballibaba2

  committed
  cd98e33

  Copy full SHA for cd98e33

• Adds cast for safety.

  Alliballibaba2

  committed
  4e2a2c6

  Copy full SHA for 4e2a2c6

• Fixes waitgroup overflow.

  Alliballibaba2

  committed
  c51eb93

  Copy full SHA for c51eb93

Commits on Nov 6, 2024

• Resolves waitgroup race condition on startup.

  Alliballibaba2

  committed
  89d8e26

  Copy full SHA for 89d8e26

Commits on Nov 7, 2024

• Moves worker request logic to worker.go.

  Alliballibaba2

  committed
  3587243

  Copy full SHA for 3587243

• Removes defer.

  Alliballibaba2

  committed
  ec32f0c

  Copy full SHA for ec32f0c

Commits on Nov 11, 2024

• Removes call from go to c.

  Alliballibaba2

  committed
  4e35698

  Copy full SHA for 4e35698

Commits on Nov 15, 2024

• Merge branch 'main' into refactor/start-worker-threads-directly

  Show description for 740fac7
  Alliballibaba2

  committed
  740fac7

  Copy full SHA for 740fac7

• Fixes merge conflict.

  Alliballibaba2

  committed
  8a272cb

  Copy full SHA for 8a272cb

• Adds fibers test back in.

  Alliballibaba2

  committed
  ecce5d5

  Copy full SHA for ecce5d5

• Refactors new thread loop approach.

  Alliballibaba2

  committed
  06ebd67

  Copy full SHA for 06ebd67

Commits on Nov 16, 2024

• Removes redundant check.

  Alliballibaba2

  committed
  c811f4a

  Copy full SHA for c811f4a

• Adds compareAndSwap.

  Alliballibaba2

  committed
  6bd047a

  Copy full SHA for 6bd047a

Commits on Nov 17, 2024

• Refactor: removes global waitgroups and uses a 'thread state' abstraction instead.

  Alliballibaba2

  committed
  55ad8ba

  Copy full SHA for 55ad8ba

• Merge branch 'main' into refactor/start-worker-threads-directly

  Show description for 3ffbe06
  Alliballibaba2

  committed
  3ffbe06

  Copy full SHA for 3ffbe06

• Removes unnecessary method.

  Alliballibaba2

  committed
  01ed92b

  Copy full SHA for 01ed92b

• Updates comment.

  Alliballibaba2

  committed
  790cccc

  Copy full SHA for 790cccc

Commits on Nov 18, 2024

• Removes unnecessary booleans.

  Alliballibaba2

  committed
  0dd2605

  Copy full SHA for 0dd2605

Commits on Nov 24, 2024

• test

  Alliballibaba2

  committed
  60a66b4

  Copy full SHA for 60a66b4

Commits on Nov 25, 2024

• First state machine steps.

  Alliballibaba2

  committed
  4719fa8

  Copy full SHA for 4719fa8

Commits on Dec 6, 2024

• Splits threads.

  Alliballibaba2

  committed
  f72e8cb

  Copy full SHA for f72e8cb

• Minimal working implementation with broken tests.

  Alliballibaba2

  committed
  d20e706

  Copy full SHA for d20e706

• Fixes tests.

  Alliballibaba2

  committed
  6747d15

  Copy full SHA for 6747d15

Commits on Dec 7, 2024

• Refactoring.

  Alliballibaba2

  committed
  54dc267

  Copy full SHA for 54dc267

• Merge branch 'main' into refactor/start-worker-threads-directly

  Show description for 660efcd
  Alliballibaba2

  committed
  660efcd

  Copy full SHA for 660efcd

• Fixes merge conflicts.

  Alliballibaba2

  committed
  6214754

  Copy full SHA for 6214754

• Formatting

  Alliballibaba2

  committed
  00eb834

  Copy full SHA for 00eb834

• C formatting.

  Alliballibaba2

  committed
  02b73b1

  Copy full SHA for 02b73b1

• More cleanup.

  Alliballibaba2

  committed
  421904e

  Copy full SHA for 421904e

• Allows for clean state transitions.

  Alliballibaba2

  committed
  cca2a00

  Copy full SHA for cca2a00

• Adds state tests.

  Alliballibaba2

  committed
  ec8aeb7

  Copy full SHA for ec8aeb7

• Adds support for thread transitioning.

  Alliballibaba2

  committed
  b598bd3

  Copy full SHA for b598bd3

• Fixes the testdata path.

  Alliballibaba2

  committed
  66cedbd

  Copy full SHA for 66cedbd

• Formatting.

  Alliballibaba2

  committed
  06af5d5

  Copy full SHA for 06af5d5

• Allows transitioning back to inactive state.

  Alliballibaba2

  committed
  71c16bc

  Copy full SHA for 71c16bc

• Fixes go linting.

  Alliballibaba2

  committed
  5095342

  Copy full SHA for 5095342

• Formatting.

  Alliballibaba2

  committed
  4b18059

  Copy full SHA for 4b18059

• Removes duplication.

  Alliballibaba2

  committed
  15429d9

  Copy full SHA for 15429d9

• Applies suggestions by @dunglas

  Alliballibaba2

  committed
  c080608

  Copy full SHA for c080608

• Removes redundant check.

  Alliballibaba2

  committed
  a166b87

  Copy full SHA for a166b87

• Locks the handler on restart.

  Alliballibaba2

  committed
  9491e6b

  Copy full SHA for 9491e6b

Commits on Dec 8, 2024

• Removes unnecessary log.

  Alliballibaba2

  committed
  e795c86

  Copy full SHA for e795c86

• Adds frankenphp admin api.

  Alliballibaba2

  committed
  68fa124

  Copy full SHA for 68fa124

• Allows booting threads at runtime.

  Alliballibaba2

  committed
  b6cbfae

  Copy full SHA for b6cbfae

• Adds proper admin status codes and tests.

  Alliballibaba2

  committed
  f185279

  Copy full SHA for f185279

• Makes config smaller.

  Alliballibaba2

  committed
  ea0a4fe

  Copy full SHA for ea0a4fe

• Adds max threads option and debug status.

  Alliballibaba2

  committed
  fcb5f8c

  Copy full SHA for fcb5f8c

• Adds test with debug message.

  Alliballibaba2

  committed
  a43ecbe

  Copy full SHA for a43ecbe

• Formatting and comments.

  Alliballibaba2

  committed
  b117bff

  Copy full SHA for b117bff

Commits on Dec 9, 2024

• Changes Unpin() logic as suggested by @withinboredom

  Alliballibaba2

  committed
  ef1bd0d

  Copy full SHA for ef1bd0d

• Allows scaling regular threads.

  Alliballibaba2

  committed
  8cd9061

  Copy full SHA for 8cd9061

• Only allows POST requests.

  Alliballibaba2

  committed
  9e8d8f0

  Copy full SHA for 9e8d8f0

Commits on Dec 10, 2024

• Adds suggestions by @dunglas and resolves TODO.

  Alliballibaba2

  committed
  a8a4545

  Copy full SHA for a8a4545

• Makes restarts fully safe.

  Alliballibaba2

  committed
  23a6362

  Copy full SHA for 23a6362

• Merge branch 'refactor/start-worker-threads-directly' into feat/worker-admin-api

  Show description for 62224bf
  Alliballibaba2

  committed
  62224bf

  Copy full SHA for 62224bf

• Will make the initial startup fail even if the watcher is enabled (as is currently the case)

  Alliballibaba2

  committed
  18e3e58

  Copy full SHA for 18e3e58

• Also adds compareAndSwap to the test.

  Alliballibaba2

  committed
  3672c60

  Copy full SHA for 3672c60

• Adds comment.

  Alliballibaba2

  committed
  38f87b7

  Copy full SHA for 38f87b7

• Merge branch 'refactor/start-worker-threads-directly' into feat/worker-admin-api

  Show description for 96265d3
  Alliballibaba2

  committed
  96265d3

  Copy full SHA for 96265d3

• Prevents panic on initial watcher startup.

  Alliballibaba2

  committed
  d97ebfe

  Copy full SHA for d97ebfe

Commits on Dec 11, 2024

• Merge branch 'refactor/start-worker-threads-directly' into feat/worker-admin-api

  Show description for 950a509
  Alliballibaba2

  committed
  950a509

  Copy full SHA for 950a509

• Cleans up admin endpoints.

  Alliballibaba2

  committed
  5f1ec1f

  Copy full SHA for 5f1ec1f

• Fixes admin test.

  Alliballibaba2

  committed
  7c61dfa

  Copy full SHA for 7c61dfa

• Boots a thread in a test.

  Alliballibaba2

  committed
  2af993e

  Copy full SHA for 2af993e

• Sets more explicit max_threads.

  Alliballibaba2

  committed
  547139f

  Copy full SHA for 547139f

Commits on Dec 12, 2024

• Adjusts naming.

  Alliballibaba2

  committed
  c8bf1ec

  Copy full SHA for c8bf1ec

• Adds docs.

  Alliballibaba2

  committed
  7f2b94e

  Copy full SHA for 7f2b94e

• Changes logic to actually terminate the thread.

  Alliballibaba2

  committed
  df78254

  Copy full SHA for df78254

Commits on Dec 13, 2024

• Removes the test's randomness.

  Alliballibaba2

  committed
  ec0bc0f

  Copy full SHA for ec0bc0f

• Adds comments.

  Alliballibaba2

  committed
  8f10407

  Copy full SHA for 8f10407

• Adds comments.

  Alliballibaba2

  committed
  91c324d

  Copy full SHA for 91c324d

Commits on Dec 15, 2024

• Scaling v1.

  Alliballibaba2

  committed
  ff06bd7

  Copy full SHA for ff06bd7

• Scaling v2.

  Alliballibaba2

  committed
  50ba106

  Copy full SHA for 50ba106

• Allows regular thread scaling.

  Alliballibaba2

  committed
  bfe3de1

  Copy full SHA for bfe3de1

• Refactors wait-time.

  Alliballibaba2

  committed
  e9f62b9

  Copy full SHA for e9f62b9

• Explicitly requires setting max_threads.

  Alliballibaba2

  committed
  21949dd

  Copy full SHA for 21949dd

• Removes redundant check.

  Alliballibaba2

  committed
  39a7fc9

  Copy full SHA for 39a7fc9

• Removes unnecessary import.

  Alliballibaba2

  committed
  442a558

  Copy full SHA for 442a558

Commits on Dec 17, 2024

• Records clock time.

  Alliballibaba2

  committed
  c213fc9

  Copy full SHA for c213fc9

• Saves CPU metrics of last 100 requests.

  Alliballibaba2

  committed
  58daaa5

  Copy full SHA for 58daaa5

Commits on Dec 18, 2024

• Integrates CPU tracking.

  Alliballibaba2

  committed
  14925f6

  Copy full SHA for 14925f6

Commits on Dec 19, 2024

• Replaces clock with probing.

  Alliballibaba2

  committed
  d408bdd

  Copy full SHA for d408bdd

• fmt.

  Alliballibaba2

  committed
  8fc3293

  Copy full SHA for 8fc3293

• Adds autoscale tests.

  Alliballibaba2

  committed
  0314247

  Copy full SHA for 0314247

• Merge branch 'main' into feat/auto-scale-clock-time

  Show description for bd4af11
  Alliballibaba2

  committed
  bd4af11

  Copy full SHA for bd4af11

• Merges main.

  Alliballibaba2

  committed
  dc10546

  Copy full SHA for dc10546

• Fixes alpine (probably)

  Alliballibaba2

  committed
  3b9f577

  Copy full SHA for 3b9f577

• Fixes alpine (definitely)

  Alliballibaba2

  committed
  790ce4e

  Copy full SHA for 790ce4e

• go fmt

  Alliballibaba2

  committed
  29de62a

  Copy full SHA for 29de62a

• Removes unnecessary 'isProtected'

  Alliballibaba2

  committed
  b447412

  Copy full SHA for b447412

Commits on Dec 20, 2024

• Adds perf tests.

  Alliballibaba2

  committed
  6fa90d6

  Copy full SHA for 6fa90d6

Commits on Dec 21, 2024

• Adds request status message to thread debug status.

  Alliballibaba2

  committed
  3bd7c76

  Copy full SHA for 3bd7c76

• Adjusts performance tests.

  Alliballibaba2

  committed
  45cd915

  Copy full SHA for 45cd915

• Adds an exponential backoff on request overflow.

  Alliballibaba2

  committed
  af40470

  Copy full SHA for af40470

• Merge branch 'main' into feat/auto-scale-clock-time

  Show description for d5e8f86
  Alliballibaba2

  committed
  d5e8f86

  Copy full SHA for d5e8f86

• changes dir.

  Alliballibaba2

  committed
  c7acb25

  Copy full SHA for c7acb25

Commits on Dec 22, 2024

• Linting and formatting.

  Alliballibaba2

  committed
  8c22cbf

  Copy full SHA for 8c22cbf

• Linting and formatting.

  Alliballibaba2

  committed
  745b29b

  Copy full SHA for 745b29b

• Adds explicit scaling tests.

  Alliballibaba2

  committed
  68ae2e4

  Copy full SHA for 68ae2e4

• Adjusts perf tests.

  Alliballibaba2

  committed
  09a5caf

  Copy full SHA for 09a5caf

• Uses different worker in removal test.

  Alliballibaba2

  committed
  3cfcb11

  Copy full SHA for 3cfcb11

• More formatting fixes.

  Alliballibaba2

  committed
  cbe45fc

  Copy full SHA for cbe45fc

• Replaces inline errors and adjusts comments.

  Alliballibaba2

  committed
  1d8e973

  Copy full SHA for 1d8e973

• Formatting.

  Alliballibaba2

  committed
  bf48b14

  Copy full SHA for bf48b14

• Formatting.

  Alliballibaba2

  committed
  4f0cc8a

  Copy full SHA for 4f0cc8a

• Formatting.

  Alliballibaba2

  committed
  d483baf

  Copy full SHA for d483baf

• Merge branch 'main' into feat/auto-scale-clock-time

  Alliballibaba2

  committed
  d222520

  Copy full SHA for d222520

Commits on Dec 23, 2024

• Merge branch 'main' into feat/auto-scale-clock-time

  Alliballibaba2

  committed
  4807947

  Copy full SHA for 4807947

Commits on Dec 25, 2024

• Implements suggestions by @dunglas.

  Alliballibaba2

  committed
  eef7815

  Copy full SHA for eef7815

Commits on Dec 26, 2024

• Adds note.

  Alliballibaba2

  committed
  601a43a

  Copy full SHA for 601a43a

• Formatting.

  Alliballibaba2

  committed
  971e1dc

  Copy full SHA for 971e1dc

Commits on Dec 29, 2024

• suggestion: Refactor scaling strategy (#1289)

  Show description for f4f9576
  withinboredom

  authored
  f4f9576

  Copy full SHA for f4f9576

• Merge branch 'feat/auto-scale-clock-time' of https://github.com/dunglas/frankenphp into feat/auto-scale-clock-time

  Alliballibaba2

  committed
  6ec9ad9

  Copy full SHA for 6ec9ad9

• Resets strategy and fixes tests.

  Alliballibaba2

  committed
  5282e32

  Copy full SHA for 5282e32

• Adds scaling strategies.

  Alliballibaba2

  committed
  83d8c11

  Copy full SHA for 83d8c11

• Fixes test reloading.

  Alliballibaba2

  committed
  c094680

  Copy full SHA for c094680

Commits on Dec 30, 2024

• Prevents threads from respawning after shutdown.

  Alliballibaba2

  committed
  3ba080a

  Copy full SHA for 3ba080a

• Adjusts transition tests.

  Alliballibaba2

  committed
  7934b50

  Copy full SHA for 7934b50

Commits on Jan 9, 2025

• Simplifies scaling.

  Alliballibaba2

  committed
  eb5e76d

  Copy full SHA for eb5e76d

• Merge branch 'main' into feat/auto-scale-clock-time

  Alliballibaba2

  committed
  f33aaad

  Copy full SHA for f33aaad

• Shows the original request path in debug status.

  Alliballibaba2

  committed
  5f70afb

  Copy full SHA for 5f70afb

Commits on Jan 10, 2025

• Adds automatic thread limit calculation.

  Alliballibaba2

  committed
  9dcc2cd

  Copy full SHA for 9dcc2cd

• Properly forwards automatic max threads.

  Alliballibaba2

  committed
  ed90b75

  Copy full SHA for ed90b75

• Adds ini overrides.

  Alliballibaba2

  committed
  d047149

  Copy full SHA for d047149

• Adds Caddy php ini directive (for testing)

  Alliballibaba2

  committed
  5bdd50c

  Copy full SHA for 5bdd50c

• Adds explicit nil check

  Alliballibaba2

  committed
  936556b

  Copy full SHA for 936556b

• Adds php.ini override test.

  Alliballibaba2

  committed
  6758903

  Copy full SHA for 6758903

• Fixes linting and conversions.

  Alliballibaba2

  committed
  548d095

  Copy full SHA for 548d095

• Fixes fuzzing tests.

  Alliballibaba2

  committed
  2761d9c

  Copy full SHA for 2761d9c

• clang-format

  Alliballibaba2

  committed
  36d3f54

  Copy full SHA for 36d3f54

• Checks for original request existence on debug status.

  Alliballibaba2

  committed
  cd5c905

  Copy full SHA for cd5c905

• Changes the memory calculation implementation

  Alliballibaba2

  committed
  98f2279

  Copy full SHA for 98f2279

• Renames var.

  Alliballibaba2

  committed
  a16de66

  Copy full SHA for a16de66

• Reduces the stall-time.

  Alliballibaba2

  committed
  6a6d040

  Copy full SHA for 6a6d040

• Adjusts scaling logic and comments.

  Alliballibaba2

  committed
  83e0c08

  Copy full SHA for 83e0c08

• Swaps to unix sys package.

  Alliballibaba2

  committed
  79447b8

  Copy full SHA for 79447b8

Commits on Jan 11, 2025

• Only supports CPU probing on unix and SysMemory on Linux.

  Alliballibaba2

  committed
  0545e1b

  Copy full SHA for 0545e1b

• Adjusts timers and passes the main thread directly to scaling.

  Alliballibaba2

  committed
  615662e

  Copy full SHA for 615662e