Skip to content

Commit

Permalink
fix: superfluous response.WriteHeader call
Browse files Browse the repository at this point in the history
  • Loading branch information
dunglas committed Aug 24, 2023
1 parent d024c3a commit f5b599b
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 1 addition & 0 deletions frankenphp.c
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,7 @@ PHP_FUNCTION(frankenphp_handle_request) {
}

frankenphp_worker_request_shutdown();
ctx->current_request = 0;
go_frankenphp_finish_request(ctx->main_request, request, true);

RETURN_TRUE;
Expand Down
1 change: 0 additions & 1 deletion frankenphp.go
Original file line number Diff line number Diff line change
Expand Up @@ -555,7 +555,6 @@ func go_write_headers(rh C.uintptr_t, status C.int, headers *C.zend_llist) {
current = current.next
}

// FIXME: http: superfluous response.WriteHeader call from github.com/dunglas/frankenphp.go_write_headers
fc.responseWriter.WriteHeader(int(status))

if status >= 100 && status < 200 {
Expand Down

0 comments on commit f5b599b

Please sign in to comment.