-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Element Optimism NFT Trades - Ready for Review #5413
Add Element Optimism NFT Trades - Ready for Review #5413
Conversation
Workflow run id 8020798869 approved. |
Workflow run id 8020798955 approved. |
Workflow run id 8037445416 approved. |
Workflow run id 8037445432 approved. |
Workflow run id 8037729493 approved. |
Workflow run id 8037729509 approved. |
Workflow run id 8037797793 approved. |
Workflow run id 8037797760 approved. |
Workflow run id 8037860443 approved. |
Workflow run id 8037860351 approved. |
Workflow run id 8037920399 approved. |
Workflow run id 8037920373 approved. |
Workflow run id 8038148438 approved. |
Workflow run id 8038148528 approved. |
Workflow run id 8038267505 approved. |
Workflow run id 8038267649 approved. |
Workflow run id 8038392213 approved. |
Workflow run id 8038392181 approved. |
@jeff-dude I saw that you were active on GitHub, I was going to tag before but it was weekend so I thought to wait till tomorrow. This pr is ready for review so wanted to tag so the label could be updated so it isn't skipped if any reviewer wanted to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work putting the existing macro to use! 👍
Thank you for contributing to Spellbook!
Thank you for taking the time to submit code in Spellbook. A few things to consider:
Spellbook sub-projects
To prepare for Spellbook to scale in size, Dune team has started to pilot sub-projects:
tokens.erc20
and all upstream spells which help build itSpellbook contribution docs
The docs directory has been implemented to answer as many questions as possible. Please take the time to reference each
.md
file within this directory to understand how to efficiently contribute & why the repo is designed as it is 🪄Example questions to be answered:
Please navigate through the docs directory to find as much info as you can.
Note: happy to take PRs to improve the docs, let us know 🤝