Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Element Optimism NFT Trades - Ready for Review #5413

Merged
merged 10 commits into from
Feb 26, 2024

Conversation

henrystats
Copy link
Contributor

Thank you for contributing to Spellbook!

Thank you for taking the time to submit code in Spellbook. A few things to consider:

  • If you are a first-time contributor, please sign the CLA by copy & pasting exactly what the bot mentions in PR comment
  • Refer to docs section below to answer questions
  • Dune team will review submitted PRs as soon as possible

Spellbook sub-projects

To prepare for Spellbook to scale in size, Dune team has started to pilot sub-projects:

  • For a quick overview, see the GH discussion on the topic
    • Please ask questions and continue the conversation there
  • The first spell lineage to move: tokens.erc20 and all upstream spells which help build it
    • Note: Please navigate to tokens root directory to find tokens objects

Spellbook contribution docs

The docs directory has been implemented to answer as many questions as possible. Please take the time to reference each .md file within this directory to understand how to efficiently contribute & why the repo is designed as it is 🪄

Example questions to be answered:

Please navigate through the docs directory to find as much info as you can.

Note: happy to take PRs to improve the docs, let us know 🤝

@dune-eng
Copy link

Workflow run id 8020798869 approved.

@dune-eng
Copy link

Workflow run id 8020798955 approved.

@dune-eng
Copy link

Workflow run id 8037445416 approved.

@dune-eng
Copy link

Workflow run id 8037445432 approved.

@dune-eng
Copy link

Workflow run id 8037729493 approved.

@dune-eng
Copy link

Workflow run id 8037729509 approved.

@dune-eng
Copy link

Workflow run id 8037797793 approved.

@dune-eng
Copy link

Workflow run id 8037797760 approved.

@dune-eng
Copy link

Workflow run id 8037860443 approved.

@dune-eng
Copy link

Workflow run id 8037860351 approved.

@dune-eng
Copy link

Workflow run id 8037920399 approved.

@dune-eng
Copy link

Workflow run id 8037920373 approved.

@dune-eng
Copy link

Workflow run id 8038148438 approved.

@dune-eng
Copy link

Workflow run id 8038148528 approved.

@henrystats henrystats changed the title Add Element Optimism NFT Trades - awaiting Decoding Add Element Optimism NFT Trades Feb 25, 2024
@henrystats henrystats changed the title Add Element Optimism NFT Trades Add Element Optimism NFT Trades - Ready for Review Feb 25, 2024
@dune-eng
Copy link

Workflow run id 8038267505 approved.

@dune-eng
Copy link

Workflow run id 8038267649 approved.

@dune-eng
Copy link

Workflow run id 8038392213 approved.

@dune-eng
Copy link

Workflow run id 8038392181 approved.

@henrystats
Copy link
Contributor Author

@jeff-dude I saw that you were active on GitHub, I was going to tag before but it was weekend so I thought to wait till tomorrow.

This pr is ready for review so wanted to tag so the label could be updated so it isn't skipped if any reviewer wanted to review.

@jeff-dude jeff-dude requested a review from 0xRobin February 25, 2024 15:51
@jeff-dude jeff-dude added ready-for-review this PR development is complete, please review and removed WIP work in progress blocked labels Feb 25, 2024
Copy link
Collaborator

@0xRobin 0xRobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work putting the existing macro to use! 👍

@0xRobin 0xRobin added ready-for-merging and removed ready-for-review this PR development is complete, please review labels Feb 26, 2024
@jeff-dude jeff-dude merged commit 084b1af into duneanalytics:main Feb 26, 2024
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2024
@henrystats henrystats deleted the element-optimism-nft branch February 27, 2024 14:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dbt: nft covers the NFT dbt subproject ready-for-merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants