This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
Add --duet-color-border variable for border color #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Thanks for this! |
|
Just realised this wasn't 100% backwards compatible. Whilst the default theme kept working, it would break people's existing custom themes (since this new variable is not defined in their theme). I had to make this change to the picker's styles: -border: 1px solid var(--duet-color-border);
+border: 1px solid var(--duet-color-border, var(--duet-color-text));Now it will fallback to the old value, even for custom themes. Thankfully I hadn't released yet :) |
|
Makes sense :) |
|
Released in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41
I kept it backwards compatible by defaulting the border color to text color, as it was before