Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): Migrate aws-sdk to v3 #534

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thyming
Copy link
Contributor

@thyming thyming commented Feb 21, 2025

In this PR:

  • aws-sdk dependency and s3-blob-store are removed in favor of the latest @aws-sdk/client-s3 and @aws-sdk/lib-storage dependencies

Issues reference:

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you lint your code with pnpm lint locally prior to submission?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran build with pnpm build of your changes locally?
  • Have you successfully ran tests with pnpm test of your changes locally?
  • Have you commit using Conventional Commits?

Copy link

socket-security bot commented Feb 21, 2025

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@aws-sdk/client-s3@3.750.0 Transitive: environment, filesystem, network +94 7.97 MB amzn-oss, aws-sdk-bot, kuhe, ...2 more
npm/@aws-sdk/lib-storage@3.750.0 Transitive: environment, filesystem, network +35 1.55 MB amzn-oss, aws-sdk-bot, kuhe, ...2 more
npm/@smithy/types@4.1.0 None +1 332 kB smithy-team

View full report↗︎

Copy link

socket-security bot commented Feb 21, 2025

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Filesystem access npm/@smithy/util-body-length-node@4.0.0 🚫
Network access npm/@smithy/credential-provider-imds@4.0.1 🚫
Environment variable access npm/@smithy/credential-provider-imds@4.0.1 🚫
Environment variable access npm/@smithy/credential-provider-imds@4.0.1 🚫
Environment variable access npm/@smithy/credential-provider-imds@4.0.1 🚫
Network access npm/@smithy/fetch-http-handler@5.0.1 🚫
Environment variable access npm/@smithy/node-config-provider@4.0.1 🚫
Environment variable access npm/@smithy/shared-ini-file-loader@4.0.1 🚫
Filesystem access npm/@smithy/shared-ini-file-loader@4.0.1 🚫
Environment variable access npm/@smithy/shared-ini-file-loader@4.0.1 🚫
Environment variable access npm/@smithy/shared-ini-file-loader@4.0.1 🚫
Environment variable access npm/@smithy/shared-ini-file-loader@4.0.1 🚫
Filesystem access npm/@smithy/hash-stream-node@4.0.1 🚫
Network access npm/@smithy/node-http-handler@4.0.2 🚫
Network access npm/@smithy/node-http-handler@4.0.2 🚫
Network access npm/@smithy/node-http-handler@4.0.2 🚫

View full report↗︎

Next steps

What is filesystem access?

Accesses the file system, and could potentially read sensitive data.

If a package must read the file system, clarify what it will read and ensure it reads only what it claims to. If appropriate, packages can leave file system access to consumers and operate on data passed to it instead.

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

What is environment variable access?

Package accesses environment variables, which may be a sign of credential stuffing or data theft.

Packages should be clear about which environment variables they access, and care should be taken to ensure they only access environment variables they claim to.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/@smithy/util-body-length-node@4.0.0
  • @SocketSecurity ignore npm/@smithy/credential-provider-imds@4.0.1
  • @SocketSecurity ignore npm/@smithy/fetch-http-handler@5.0.1
  • @SocketSecurity ignore npm/@smithy/node-config-provider@4.0.1
  • @SocketSecurity ignore npm/@smithy/shared-ini-file-loader@4.0.1
  • @SocketSecurity ignore npm/@smithy/hash-stream-node@4.0.1
  • @SocketSecurity ignore npm/@smithy/node-http-handler@4.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant