Floating Action Button #85

EvergreenTree97 · 2022-09-04T05:06:08Z

What's new?

FloatingActionButton 구현
MenuFloatingActionButton 구현
zeplin 업데이트 된 아이콘 추가
kdoc 문서화
snapshot test(parameter 설정이 애매)

feat/quack-fab 으로 했어야 했는데 브랜치 네이밍 잘 맞추겠습니다

참고사항

MenuFloatingActionButton같은 경우 Dialog로 표현됨 따라서 Window 기준 offset을 재서 어디로 이동하던 간에 메뉴가 버튼 위에 위치할 수 있도록 설정

체크 리스트

Reviewer 과 Assignees 를 확인했습니다.
label 을 확인했습니다

…-quack into feat/quack_fab

jisungbin · 2022-09-04T05:13:03Z

~~스냅샷 찍어주세요~~

엥 있네요 왜 안보였지 죄송해요

codecov-commenter · 2022-09-04T05:18:45Z

Codecov Report

❗ No coverage uploaded for pull request base (develop@72eb63d). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop      #85   +/-   ##
==========================================
  Coverage           ?   33.17%           
==========================================
  Files              ?       56           
  Lines              ?     2387           
  Branches           ?      426           
==========================================
  Hits               ?      792           
  Misses             ?     1500           
  Partials           ?       95

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

jisungbin

지금 밖이라 이따 집 가서 이어서 봐드릴게요!

ui-components/src/test/kotlin/team/duckie/quackquack/ui/QuackFloatingActionButton.kt

ui-components/src/main/kotlin/team/duckie/quackquack/ui/component/image.kt

ui-components/src/main/kotlin/team/duckie/quackquack/ui/component/fab.kt

jisungbin · 2022-09-04T05:21:58Z

label 에 deploy 빠졌어요
스냅샷 배포가 안됐네요 😭

github-actions · 2022-09-04T05:55:22Z

 ______________________________________
/ 새로운 테스트 커버리지 HTML 리포트가 \
| 배포되었습니다.                      |
| https://quack-test.duckie.team/ 에서 |
\ 확인하실 수 있습니다.                /
 --------------------------------------
     \
      \
          oO)-.                       .-(Oo
         /__  _\                     /_  __\
         \  \(  |     ()~()         |  )/  /
          \__|\ |    (-___-)        | /|__/
          '  '--'    ==`-'==        '--'  '

github-actions · 2022-09-04T05:55:24Z

 _________________________________________
/ 새로운 UI 컴포넌트 스냅샷이배포되었습니 \
| 다.                                     |
| https://quack-ui.duckie.team/ 에서      |
\ 확인하실 수 있습니다.                   /
 -----------------------------------------
    \
     \
    ^__^         /
    (oo)\_______/  _________
    (__)\       )=(  ____|_ \_____
        ||----w |  \ \     \_____ |
        ||     ||   ||           ||

jisungbin

퍼포먼스적으로 문제가 몇몇 있어서 고쳐야 할 거 같네요 😢
그래도 수고하셨어요! 감사합니당

ui-components/src/main/kotlin/team/duckie/quackquack/ui/component/fab.kt

ui-components/src/main/res/drawable/ic_dm_new_20_white.xml

ui-components/src/test/kotlin/team/duckie/quackquack/ui/QuackFab.kt

jisungbin · 2022-09-04T08:52:49Z

아맞다! 플레이그라운드 추가도 필요해요

ui-components/src/main/kotlin/team/duckie/quackquack/ui/component/fab.kt

EvergreenTree97 · 2022-09-06T07:08:02Z

요거 QuackMainTabTextLazyRow 참고하시고 한 번 수정해서 적용해보시겠어요?

onTabContainerSizeChanged = { size ->
                tabHeight = size.height
},

요 콜백은 Density를 따로 사용하지 않는 듯 한데 이유가 있을까요?

jisungbin · 2022-09-06T10:07:55Z

요 콜백은 Density를 따로 사용하지 않는 듯 한데 이유가 있을까요?

필요한 값 단위가 픽셀이기 때문입니다. @EvergreenTree97

…nt parameter class로 변경

…-quack into feat/quack_fab

EvergreenTree97 added 8 commits September 4, 2022 02:35

test: 스냅샷 테스트

bc6cb5c

feat: click 이벤트 없는 icon

ba17c33

feat; fab버튼 dialog 수정 필요

b1d02b7

Merge branch 'develop' of https://github.com/sungbinland/duckie-quack…

5c9e5c7

…-quack into feat/quack_fab

feat: fab 버튼 구현

d9f0696

feat: icon 추가

6219c47

feat: icon 추가

a599467

test: 스냅샷 테스트

b3c7089

EvergreenTree97 added UI documentation Rebuild project website labels Sep 4, 2022

EvergreenTree97 requested a review from goddoro September 4, 2022 05:06

EvergreenTree97 self-assigned this Sep 4, 2022

EvergreenTree97 requested a review from jisungbin as a code owner September 4, 2022 05:06

EvergreenTree97 changed the title ~~Feat/quack fab~~ Floating Action Button Sep 4, 2022

jisungbin reviewed Sep 4, 2022

View reviewed changes

EvergreenTree97 added deploy and removed deploy labels Sep 4, 2022

EvergreenTree97 added 3 commits September 4, 2022 14:48

remove: nonClickableImage 삭제

54927c1

test: 스냅샷 테스트 네이밍 변경

ee10633

refactor: quackClickable 사용 및 NonclickImageIcon 삭제

98e2d57

jisungbin suggested changes Sep 4, 2022

View reviewed changes

jisungbin reviewed Sep 4, 2022

View reviewed changes

ui-components/src/main/kotlin/team/duckie/quackquack/ui/component/fab.kt Show resolved Hide resolved

EvergreenTree97 added 6 commits September 6, 2022 16:15

refactor: offset 함수 변경

bb084f4

refactor: 불필요한 null 제거

1854bbb

refactor: QuackText에 style 주는 대신 대신 QuackSubTitle 사용

04b81ca

refactor: Playground argument 변경

f82179e

refactor: expanded 제어권 제공

d7f2a63

test: 스냅샷 테스트 expanded parameter로 제공

17c816e

EvergreenTree97 added 18 commits September 6, 2022 20:02

refactor: Spacer 제거 후 padding으로 대체

7d751b7

refactor: QuackPopupItem -> QuackDialogItem 네이밍 변경 및 DialogMenu Conte…

0945183

…nt parameter class로 변경

feat: Item과 Text 사이 간격 추가

c6b45cf

refactor: QuackPopupItem -> QuackDialogItem으로 변경

7a7269c

refactor: Column 에서 LazyColumn 으로 변경

f5b85bd

refactor: @NonRestartableComposable 불필요한 것들 제거하고 필요한 것 추가

9e72012

feat: class에 hashcode와 equals 추가

146fe05

feat: AnimatedVisibility 적용

38099fc

refactor: Item의 중복 클릭 이벤트 없애고, (QuackDialogMenuItem) -> Unit 람다 추가

ca63030

test: 파라미터 변경에 따라 람다 추가

a301b21

refactor: named arguments 추가

1a6a8ff

docs: 파라미터 변경에 따른 Kdoc 변경

83729e3

Merge branch 'develop' of https://github.com/sungbinland/duckie-quack…

2cc59d4

…-quack into feat/quack_fab

refactor: fab offset,size 람다로 구현

f8ed180

refactor: Playground Box로 변경

3ac360b

fix: NewLine 추가

fe588ee

refactor: lint module 린트 에러

27071e0

refactor: offset 구하는거 kdoc에 자세히 명시 및 린트 에러 수정

1833c3b

jisungbin added the release Releasing a current version of the Catalog label Sep 11, 2022

jisungbin merged commit 89eae3a into develop Sep 11, 2022

jisungbin deleted the feat/quack_fab branch September 11, 2022 06:33

jisungbin temporarily deployed to github-pages September 11, 2022 06:33 Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Floating Action Button #85

Floating Action Button #85

EvergreenTree97 commented Sep 4, 2022 •

edited by jisungbin

Loading

jisungbin commented Sep 4, 2022 •

edited

Loading

codecov-commenter commented Sep 4, 2022 •

edited

Loading

jisungbin left a comment

jisungbin commented Sep 4, 2022 •

edited

Loading

github-actions bot commented Sep 4, 2022

github-actions bot commented Sep 4, 2022

jisungbin left a comment

jisungbin commented Sep 4, 2022 •

edited

Loading

EvergreenTree97 commented Sep 6, 2022 •

edited

Loading

jisungbin commented Sep 6, 2022 •

edited

Loading

Floating Action Button #85

Floating Action Button #85

Conversation

EvergreenTree97 commented Sep 4, 2022 • edited by jisungbin Loading

What's new?

체크 리스트

jisungbin commented Sep 4, 2022 • edited Loading

codecov-commenter commented Sep 4, 2022 • edited Loading

Codecov Report

jisungbin left a comment

Choose a reason for hiding this comment

jisungbin commented Sep 4, 2022 • edited Loading

github-actions bot commented Sep 4, 2022

github-actions bot commented Sep 4, 2022

jisungbin left a comment

Choose a reason for hiding this comment

jisungbin commented Sep 4, 2022 • edited Loading

EvergreenTree97 commented Sep 6, 2022 • edited Loading

jisungbin commented Sep 6, 2022 • edited Loading

EvergreenTree97 commented Sep 4, 2022 •

edited by jisungbin

Loading

jisungbin commented Sep 4, 2022 •

edited

Loading

codecov-commenter commented Sep 4, 2022 •

edited

Loading

jisungbin commented Sep 4, 2022 •

edited

Loading

jisungbin commented Sep 4, 2022 •

edited

Loading

EvergreenTree97 commented Sep 6, 2022 •

edited

Loading

jisungbin commented Sep 6, 2022 •

edited

Loading