Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PULL_REQUEST_TEMPLATE.md #72

Merged
merged 3 commits into from
Aug 30, 2022
Merged

Update PULL_REQUEST_TEMPLATE.md #72

merged 3 commits into from
Aug 30, 2022

Conversation

riflockle7
Copy link
Contributor

What's new?

  1. PR 템플릿에 체크리스트 항목을 추가했습니다.

@riflockle7 riflockle7 mentioned this pull request Aug 29, 2022
3 tasks
@jisungbin
Copy link
Contributor

  • label 을 확인했습니다
  • label 추가 내용을 확인했습니다.

요거 2개의 차이점은 무엇일까요?

@riflockle7
Copy link
Contributor Author

github markdown 작성하다가 꼬인거 같네요. 수정했습니다

Copy link
Contributor

@jisungbin jisungbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니당 ㅎㅎ 수고하셨어요!

@@ -18,3 +18,7 @@ PR 요청하실 때 상황에 맞는 label 을 꼭 달아주세요! **아래 리
2. ...
3. ...
4. ...

## 체크 리스트
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

근데 요기 사이에 공백 한 줄만 넣어주실 수 있나요?
이걸 못봤네요

한 줄 넣는게 마크다운 스타일가이드에 맞아요!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넣어주시고 머지 눌러주시면 될 거 같아요!

@jisungbin jisungbin merged commit 619350e into develop Aug 30, 2022
@jisungbin jisungbin deleted the riflockle7-patch-1 branch August 30, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants