Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuackTextField 완성 #132

Merged
merged 37 commits into from
Sep 26, 2022
Merged

QuackTextField 완성 #132

merged 37 commits into from
Sep 26, 2022

Conversation

jisungbin
Copy link
Contributor

@jisungbin jisungbin commented Sep 26, 2022

Overview (Required)

  • QuackTextField 를 디자인 스팩에 맞게 완성하였습니다.
  • 플레이그라운드 UI 를 개선하였습니다.
    • Dynamic Color 적용
    • PreviewAlert 구조 변경

- rememberQuackTextFieldMeasurePolicy() 추가
- 유틸 코드들 layout.kt 파일로 이동
@jisungbin jisungbin added UI documentation Rebuild project website release Releasing a current version of the Catalog labels Sep 26, 2022
@jisungbin jisungbin self-assigned this Sep 26, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (develop@e7d73a1). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #132   +/-   ##
==========================================
  Coverage           ?   43.87%           
==========================================
  Files              ?       69           
  Lines              ?     3348           
  Branches           ?      623           
==========================================
  Hits               ?     1469           
  Misses             ?     1701           
  Partials           ?      178           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

 ______________________________________
/ 새로운 테스트 커버리지 HTML 리포트가 \
| 배포되었습니다.                      |
| https://quack-test.duckie.team/ 에서 |
\ 확인하실 수 있습니다.                /
 --------------------------------------
   \         ,        ,
    \       /(        )`
     \      \ \___   / |
            /- _  `-/  '
           (/\/ \ \   /\
           / /   | `    \
           O O   ) /    |
           `-^--'`<     '
          (_.)  _  )   /
           `.___/`    /
             `-----' /
<----.     __ / __   \
<----|====O)))==) \) /====
<----'    `--' `.__,' \
             |        |
              \       /
        ______( (_  / \______
      ,'  ,-----'   |        \
      `--{__________)        \/

@github-actions
Copy link

 _________________________________________
/ 새로운 UI 컴포넌트 스냅샷이배포되었습니 \
| 다.                                     |
| https://quack-ui.duckie.team/ 에서      |
\ 확인하실 수 있습니다.                   /
 -----------------------------------------
       \   \_______
 v__v   \  \   O   )
 (oo)      ||----w |
 (__)      ||     ||  \/\
    

@EvergreenTree97
Copy link
Contributor

EvergreenTree97 commented Sep 26, 2022

image
-> two line

image
-> bottom line과 간격

위 사항들은 의도된 것인가요?? 혹은 스냅샷 에러일까여

@jisungbin
Copy link
Contributor Author

@EvergreenTree97 two-line 으로 나뉘어 지는건 원인을 모르겠어요 BasicTextField 로 넘길때는 singleLine = true 로 넘기고 있습니다.

bottom line 과 간격은 아마 TextField content 가 밑으로 내려갔는데 짤린 듯 하네여

@jisungbin jisungbin merged commit 829f674 into develop Sep 26, 2022
@jisungbin jisungbin deleted the fix/textfield branch September 26, 2022 03:33
@jisungbin jisungbin temporarily deployed to github-pages September 26, 2022 03:33 Inactive
@github-actions
Copy link

 ______________________________________
/ 새로운 테스트 커버리지 HTML 리포트가 \
| 배포되었습니다.                      |
| https://quack-test.duckie.team/ 에서 |
\ 확인하실 수 있습니다.                /
 --------------------------------------
   \
    \
    ____  
   /# /_\_
  |  |/o\o\
  |  \\_/_/
 / |_   |  
|  ||\_ ~| 
|  ||| \/  
|  |||_    
 \//  |    
  ||  |    
  ||_  \   
  \_|  o|  
  /\___/   
 /  ||||__ 
    (___)_)

@github-actions
Copy link

 _________________________________________
/ 새로운 UI 컴포넌트 스냅샷이배포되었습니 \
| 다.                                     |
| https://quack-ui.duckie.team/ 에서      |
\ 확인하실 수 있습니다.                   /
 -----------------------------------------
     \
      \  (__)  
         (\/)  
  /-------\/    
 / | 666 ||    
*  ||----||      
   ~~    ~~      

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Rebuild project website release Releasing a current version of the Catalog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants