Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #102

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Update README.md #102

merged 1 commit into from
Sep 13, 2022

Conversation

GibsonRuitiari
Copy link
Contributor

@GibsonRuitiari GibsonRuitiari commented Sep 13, 2022 •
edited by jisungbin
Loading

Updated Readme

Improved the tone, tense and words used in readme.md.

@jisungbin
Copy link
Contributor

👀

@jisungbin
Copy link
Contributor

Hmmm, CI failed, but I think there is a problem with our CI. Your PR is a simple document modification, so it doesn't directly affect the code. In other words, it doesn't matter if the CI fails (I think 😅). Thanks for the first contribution!

@jisungbin jisungbin merged commit 5fb3970 into duckie-team:develop Sep 13, 2022
@jisungbin
Copy link
Contributor

Also, I'm not good at English, so I needed a contribution like this. 🙌 ❤️

@GibsonRuitiari
Copy link
Contributor Author

The CI is failing because there are no secret keys. I think you need to make the default secret keys available during the CI builds or do away with it all together haha.
Anyway, you are welcome, friend.

@jisungbin
Copy link
Contributor

The CI is failing because there are no secret keys. I think you need to make the default secret keys available during the CI builds or do away with it all together haha. Anyway, you are welcome, friend.

That's right, I saw the CI log. I will fix this problem soon. thank you!

@jisungbin jisungbin mentioned this pull request Sep 13, 2022
Merged
@jisungbin jisungbin self-assigned this Sep 13, 2022
@jisungbin jisungbin added the enhancement New features or improvements label Sep 13, 2022
@jisungbin jisungbin removed their assignment Sep 13, 2022
jisungbin added a commit that referenced this pull request Sep 13, 2022
@jisungbin
feat: fix the problem that CI failing in external PR (#103)
97c3163 
see: #102 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jisungbin jisungbin jisungbin approved these changes

Assignees
No one assigned
Labels
enhancement New features or improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GibsonRuitiari @jisungbin