feat: fix snapshot actions (#244)

* refactor: AnimationTestRule 코드 스타일 정리 * feat: paparazzi 디바이스 옵션 추가 * refactor: if 위치 변경 * refactor: 사용하지 않는 테스트 인자 제거 * feat: 잘못된 if 구문 정정
duckie-team · Oct 8, 2022 · c109124 · c109124
1 parent 4736639
commit c109124
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 11 deletions.
diff --git a/.github/workflows/artifact-publish.yml b/.github/workflows/artifact-publish.yml
@@ -13,6 +13,7 @@ on:
 
 jobs:
   artifacts-publish:
+    runs-on: ubuntu-latest
     if: ${{
       github.event.pull_request.merged &&
       contains(github.event.pull_request.labels.*.name, 'publish') &&
@@ -26,7 +27,6 @@ jobs:
       contains(github.event.pull_request.labels.*.name, 'target_ui-components')
       )
       }}
-    runs-on: ubuntu-latest
 
     steps:
       - uses: actions/checkout@v3

diff --git a/.github/workflows/playground-release.yml b/.github/workflows/playground-release.yml
@@ -8,15 +8,15 @@ on:
 
 jobs:
   playground-release:
+    runs-on: ubuntu-latest
     if: ${{
-        github.event.pull_request.merged &&
-        contains(github.event.pull_request.labels.*.name, 'release') &&
-        (contains(github.event.pull_request.labels.*.name, 'bump_major') ||
-          contains(github.event.pull_request.labels.*.name, 'bump_minor') ||
-          contains(github.event.pull_request.labels.*.name, 'bump_patch')
-        )
+      github.event.pull_request.merged &&
+      contains(github.event.pull_request.labels.*.name, 'release') &&
+      (contains(github.event.pull_request.labels.*.name, 'bump_major') ||
+      contains(github.event.pull_request.labels.*.name, 'bump_minor') ||
+      contains(github.event.pull_request.labels.*.name, 'bump_patch')
+      )
       }}
-    runs-on: ubuntu-latest
 
     steps:
       - uses: actions/checkout@v3

diff --git a/.github/workflows/verify-snapshots-failed-comment.yml b/.github/workflows/verify-snapshots-failed-comment.yml
@@ -9,7 +9,8 @@ on:
 jobs:
   comment:
     runs-on: ubuntu-latest
-    if: verify-snapshots-failed-comment.yml
+    if: github.event.workflow_run.conclusion == 'success'
+
     steps:
       - name: Download snapshots verify result
         uses: actions/github-script@v3.1.1

diff --git a/ui-components-snapshots/src/test/kotlin/team/duckie/quackquack/ui/snapshot/QuackTag.kt b/ui-components-snapshots/src/test/kotlin/team/duckie/quackquack/ui/snapshot/QuackTag.kt
@@ -127,13 +127,11 @@ class QuackTag {
     )
     @Test
     fun QuackRowTag(
-        @TestParameter isSelected: Boolean,
         @TestParameter("1.0", "1.5") fontScale: Float,
         @TestParameter deviceConfig: QuackDeviceConfig,
     ) {
         paparazzi.boxSnapshot(
             parameterNames = listOf(
-                "isSelected",
                 "fontScale",
                 "deviceConfig",
             ),