-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for Azure secrets #478
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Some small nitpicks.
@@ -157,6 +157,18 @@ Querying data stored in Parquet, CSV, JSON, Iceberg and Delta format can be done | |||
LIMIT 100; | |||
``` | |||
|
|||
Note, for Azure, you will need to first install the Azure extension: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should call out somewhere that writes to Azure are not yet supported, linking to this issue: duckdb/duckdb-azure#44
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a note below in the readme, let me know what you think.
This reverts commit f466372.
Add support for Azure secrets: