Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Azure secrets #478

Merged
merged 6 commits into from
Dec 5, 2024
Merged

feat: Add support for Azure secrets #478

merged 6 commits into from
Dec 5, 2024

Conversation

Y--
Copy link
Collaborator

@Y-- Y-- commented Dec 4, 2024

Add support for Azure secrets:

  1. Install Azure extension
SELECT duckdb.install_extension('azure');
  1. Add a secret:
INSERT INTO duckdb.secrets
(type, connection_string)
VALUES ('Azure', '<your connection string>');
  1. Run a query:
SELECT count(*) 
FROM read_parquet('azure://my_container/orders.parquet') AS (order_id int);

@Y-- Y-- force-pushed the yl/azure-support branch from 50789a7 to 4bbda4f Compare December 4, 2024 14:24
@Y-- Y-- requested review from JelteF and mkaruza and removed request for JelteF December 4, 2024 14:28
Copy link
Collaborator

@JelteF JelteF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Some small nitpicks.

src/pgduckdb_duckdb.cpp Outdated Show resolved Hide resolved
@@ -157,6 +157,18 @@ Querying data stored in Parquet, CSV, JSON, Iceberg and Delta format can be done
LIMIT 100;
```

Note, for Azure, you will need to first install the Azure extension:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should call out somewhere that writes to Azure are not yet supported, linking to this issue: duckdb/duckdb-azure#44

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a note below in the readme, let me know what you think.

src/pgduckdb_duckdb.cpp Show resolved Hide resolved
sql/pg_duckdb--0.1.0--0.2.0.sql Outdated Show resolved Hide resolved
@Y-- Y-- requested a review from JelteF December 4, 2024 17:18
@Y-- Y-- enabled auto-merge (squash) December 5, 2024 12:27
@Y-- Y-- merged commit bb82c93 into main Dec 5, 2024
5 checks passed
@Y-- Y-- deleted the yl/azure-support branch December 5, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants