Heap reading optimization and fixes #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Y--
reviewed
Oct 29, 2024
Currently we use map to match duckdb output column idx to postgres column id. For column filter we would also do lookup for each column. This is not needed as this information are not changed during scan of heap tables. Optimization is based on idea to construct vector that holds these mapping information so map lookups are not needed anymmore. For filtering, same logic is applied, now we would have vector of column filters.
Currently we are creating BufferAccessStrategy for each page fetch. With help of @MMeent issue was identified and this commit fixes this problem by creating BufferAccessStrategy for each scan instead.
JelteF
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
These look like good changes to me. I'm still planning to look at refactoring this code a bit more to make the different indexes and arrays easier to understand. But for that I need to try a few things and play around with the code. The current PR is already much easier to follow than before.
|
Let's add PR numbers to the commit message titles though for easy reference if you're not doing a squash merge. |
Y--
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR contains two commits that are supposed to be committed separately.
First commit improves performances of reading heap tuples and writing them back to duckdb output vector by converting map lookups into vector structures that are read sequentially for each row.
Second commit addresses problem of creating BufferAccessStrategy for each page read and creates single object for complete duration of scan execution.