Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support postgresql 14 #178

Closed
wants to merge 1 commit into from
Closed

Conversation

Leo-XM-Zeng
Copy link
Contributor

Postgres 14
370f3892b310b4e608e27058b9a433f
make check
727051217ca72a6cca0e24506cf2f2c

@Leo-XM-Zeng
Copy link
Contributor Author

Hello, I can try to support postgresql 15 if needed

Copy link
Collaborator

@JelteF JelteF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your effort here. A few things before I think this can be merged:

  1. I think merging this, requires adding PG15 support as well. Leaving a gap of the versions we support between PG14 and PG16 seems too confusing.
  2. PG14 (and PG15) should be added to Github Actions testing
  3. The original PG ruleutils should be added in a separate commit from the rest of the changes, just like I did in Vendor in Postgres ruleutils and handle public.read_csv #140. That will make it easy to track where certain lines of code come from using git blame.

@Leo-XM-Zeng
Copy link
Contributor Author

Thanks a lot for your effort here. A few things before I think this can be merged:

  1. I think merging this, requires adding PG15 support as well. Leaving a gap of the versions we support between PG14 and PG16 seems too confusing.
  2. PG14 (and PG15) should be added to Github Actions testing
  3. The original PG ruleutils should be added in a separate commit from the rest of the changes, just like I did in Vendor in Postgres ruleutils and handle public.read_csv #140. That will make it easy to track where certain lines of code come from using git blame.

Ok, thank you for your guidance. Then I will finish PG15 first as required

@Leo-XM-Zeng Leo-XM-Zeng deleted the pg_duckdb_14 branch October 9, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants