Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aggregates.md #2618

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Update aggregates.md #2618

merged 3 commits into from
Mar 29, 2024

Conversation

soerenwolfers
Copy link
Collaborator

@soerenwolfers soerenwolfers commented Mar 29, 2024

SELECT 
mode() WITHIN GROUP (ORDER BY x),
mode(x),
mode(x ORDER BY x),
FROM 
(VALUES (2), (1)) _(x)
┌───────────────────────────────────┬─────────┬────────────────────┐
│ mode() WITHIN GROUP ( ORDER BY x) │ mode(x) │ mode(x ORDER BY x) │
│               int32               │  int32  │       int32        │
├───────────────────────────────────┼─────────┼────────────────────┤
│                                 1 │       2 │                  1 │
└───────────────────────────────────┴─────────┴────────────────────┘

shows that the WITHIN GROUP aggregate is converted to something more involved than what was previously claimed.

EDIT: Related ticket at duckdb/duckdb#11419, but I still think this PR makes the docs more correct than they currently are even without that ticket being resolved yet.

@szarnyasg
Copy link
Collaborator

Thanks! That's a clever use of <code> + &#124; to make it format correctly in editors.

@szarnyasg szarnyasg merged commit 916cf02 into duckdb:main Mar 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants