-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OPFS (Origin Private File System) Support #1856
base: main
Are you sure you want to change the base?
Conversation
This is very very welcome, thanks. I am in the process of releasing a new version of duckdb-wasm, connected to duckdb |
@carlopi |
One comment would be if you could have a look at the failing test |
bbb2067
to
383ff1b
Compare
@carlopi https://github.com/AKABANAKK/duckdb-wasm/actions/runs/11016245572 |
Thanks, I gave a proper look, this looks solid, thanks a lot for the contribution. This PR does introduces some API changes that might be somewhat unexpected, so I think the proper way forward would be:
|
@carlopi |
886b161
to
54b82e9
Compare
Co-authored-by: asrar <aszenz@gmail.com>
b4159f3
to
b78525d
Compare
@carlopi |
Description:
This PR implements OPFS (Origin Private File System) support in the latest version of duckdb-wasm based on PR #1490.
This allows database files to be read and written to the OPFS.
API:
When opening a database file, you can now use the following API:
Changes: