-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump DuckDB, properly propagate wasm_* platform and add test #1328
Conversation
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 18.15.11 to 20.4.2. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
See duckdb#1298 for a bug caused by missed optimizations
Thanks for the PR! Are all the |
Yes, it's not great practice, but currently strategy of shallowing exceptions is not great since shallows both DuckDB-side exceptions (like failures) and JS exceptions (these might be harmless, and might make sense to skip in some cases). To users not opening the console, it should give roughly the same experience, but upon inspection some information of what went wrong is available. Note that exceptions are still used only for exceptional behaviour, so I would assume (but I am not completely sure) that the number of exceptions will be low (bounded by the number of failed queries ?). |
Alright, makes sense to me. Thanks |
Hi, just came across this when diagnosing log spamming during some of our tests. It would be nice to be able to disable the currently unconditional |
I guess it's unclear to me why this isn't just using the |
I moved this to an independent issue, #1518. Why this happened is an oversight on my side, there was a comment like: // Next few lines should argubly in separate JavaScript-land function call
// TODO: move them out / have them configurable that I never got to address. Fix is trivial, only problem is that this is in DuckDB codebase and will require patching while building duckdb in duckdb-wasm, but there is already infrastructure for that. |
Previously the custom provided platform was not propagated in the right place, fixed and added a test.
Fixes #1298