-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add electron build workflow #100
Conversation
Thanks for the contribution, could you have a look at why CI is failing? |
@carlopi So it was failing because I needed to add the patch version to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good, last request, could you make it so only a small subset (say up to 3?) of the electron builds are actually run on pull requests?
I could also take a look at tweaking this at some later point, but I think having like the setup step be conditional, and either use the full matrix or only selected rows it would be handy to have, since otherwise this will become very heavy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
No problem! I just filtered 2 versions that we're currently using in our repo now. :) |
@azmy60: given you have it still fresh, could you take a look at the syntax that triggers this problem https://github.com/duckdb/duckdb-node/actions/runs/9937704658: |
In attempt to support electron build as mentioned in #70.
This PR aims to build binaries for electron
18.3.x
to latest.