Fix JDBC type for DECIMAL columns; add test #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows
DECIMAL` in the case statement. This is similar to 0.9.2 behavior except the start-of-string matching is done in SQL rather than Java.
DECIMAL(W,S)
types to be interpreted asDECIMAL
JDBC type. Currently the type is returned as a genericJAVA_OBJECT
becauseDECIMAL(W,S)
does not matchI wonder if a better fix would be to use
data_type_id
fromduckdb_columns()
rather thandata_type
frominformation_schema.columns
? It would require adding hardcoded duckdb type numbers intoDuckDBColumnType
. The test is useful either way.There is a tiny unrelated improvement to
Assertions
utility, allowing the calling code to add a prefix to indicate which one of the loop iterations failed.Fixes duckdb/duckdb#11365