Add allow_asterisks_in_http_paths setting, that default to false, so … #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean also global_metadata_cache on discovering a URL is now changed
DuckDB submodule to 140
Run also slow tests, and avoid skipping HTTP-connected errors
…that Globs on HTTP file system will now throw
|
I like this, question on the default, unsure if going bold or keep it. Reasons for forbid by default: it's reasonable, and you will get an error message so you know how to act Reason to keep current default: no changes |
samansmink
reviewed
Oct 2, 2025
samansmink
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…that Globs on HTTP file system will now throw
This fix an existing
FIXMEin the code, with what I believe is a sensible default.This came up connected to running queries across different backends, and failure mode would be different, while the expected behaviour (I think) is no globs on
http://orhttps://.Old behaviour can be enabled via
SET allow_asterisks_in_http_paths = true;(and arguably, if this is to land now, default needs to be swapped)