Move over httpfs tests from main repo to duckdb-httpfs + add CI run #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Minio CI runs shows: I think this is good as is, but I would send another PR to change the default to log all as failures and review them (chances some tests are just outdated / wrong). Thanks, I think this is great! |
|
Yes, sounds good. I think these failures were already present before, e.g. see this log (note the |
Mytherin
added a commit
to duckdb/duckdb
that referenced
this pull request
Sep 25, 2025
For a while `httpfs` has been in a weird limbo land where the extension has moved out-of-tree, but the tests still resided in the main DuckDB repo. This is now fixed by duckdb/duckdb-httpfs#132 - so we can remove all of the tests from the main DuckDB repo.
|
Removed skipped error messages in #136 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves over all
httpfstests from the main repo to this repo, also including the scripts to set up and run minio in docker. It also includes the CI run that runs all of these tests as part of theIntegration Testsworkflow. The goal is to run the complete set of tests as part of theduckdb-httpfstest suite only, and rip these out of the main repo, completing the migration ofhttpfsto the new repo.This should also improve testing of PRs made to this repo as several of the settings were not correctly set up in the current MinIO tests and slow tests were not run, causing a bunch of
httpfstests to be skipped.