Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add safety check for node in graph #472

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

tehunter
Copy link
Contributor

With dbt's unit-test feature, dbt may not populate the graph when running dbt test -s model_to_test. This will result in an error in register_upstream_external_models:

on-run-start failed, error:
 'dict object' has no attribute 'unit_test.project_name.model_name.test_name'

This change checks if a node is present before looking for its dependencies.

With dbt's unit-test feature, dbt may not populate the graph when running `dbt test -s model_to_test`. This will result in an error:

```
on-run-start failed, error:
 'dict object' has no attribute 'unit_test.project_name.model_name.test_name'
```
Copy link
Collaborator

@jwills jwills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tehunter!

@jwills jwills merged commit 5b4770f into duckdb:master Oct 29, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants